Bug 55564 - [Chrome][DRT] Should roll Chromium revision up to r76362
Summary: [Chrome][DRT] Should roll Chromium revision up to r76362
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 55434
  Show dependency treegraph
 
Reported: 2011-03-02 03:03 PST by Hajime Morrita
Modified: 2011-03-02 21:06 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.28 KB, patch)
2011-03-02 03:50 PST, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (2.95 KB, patch)
2011-03-02 14:25 PST, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2011-03-02 03:03:22 PST
To use a new webkit_support API, DRT needs new revision of Chromium tree.

Note that the change will contain icu4.6 and libjpeg_turbo, which requires build bot reboots.
Comment 1 Kent Tamura 2011-03-02 03:19:48 PST
(In reply to comment #0)
> which requires build bot reboots.

Do you mean 'clobber', not 'reboot'?
Comment 2 Hajime Morrita 2011-03-02 03:50:47 PST
Created attachment 84396 [details]
Patch
Comment 3 WebKit Review Bot 2011-03-02 04:06:26 PST
Attachment 84396 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8072970
Comment 4 Kent Tamura 2011-03-02 05:49:20 PST
We need to add an entry for libjpeg_turbo to DEPS, don't we?
Also, please make sure you can build Chromium port with WebKit-only checkout and your patch.
Comment 5 Tony Chang 2011-03-02 13:55:50 PST
I'll take a stab at this.  I'm able to ssh to the bots and clobber them.
Comment 6 Tony Chang 2011-03-02 14:25:01 PST
Created attachment 84467 [details]
Patch
Comment 7 Tony Chang 2011-03-02 14:25:30 PST
Comment on attachment 84467 [details]
Patch

This works on my Linux machine.  I will try to land it this afternoon.  I don't think we need a clobber.
Comment 8 Tony Chang 2011-03-02 15:49:42 PST
http://trac.webkit.org/changeset/80174

It passed on win and linux.  I'm still waiting for mac to finish cycling.
Comment 9 Hajime Morrita 2011-03-02 21:06:15 PST
Hi Tony, Thank you for your help!
I thought we need the clobber the build, just because chromium builds did need it. 
But I don't know why. So if it can go without clobber, it's fine.