Bug 55563 – Web Inspector: [Chromium] Landing detailed heap snapshots, part 4

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Mikhail Naganov]

This part adds implementations for data grids used to display different heap snapshots projections. We are almost done.

[Mikhail Naganov]

Created attachment 84385 [details]
Screenshot -- Summary data grid

[Mikhail Naganov]

Created attachment 84386 [details]
Screenshot -- Comparison data grid

[Mikhail Naganov]

Created attachment 84387 [details]
Screenshot -- Containment data grid

[Mikhail Naganov]

Created attachment 84388 [details]
Screenshot -- Dominators data grid

[Mikhail Naganov]

Created attachment 84389 [details]
Screenshot -- Retaining paths list

[Mikhail Naganov]

Created attachment 84390 [details]
Screenshot -- Legend popup

[Alexander Pavlov (apavlov)]

(In reply to comment #6)
> Created an attachment (id=84390) [details]
> Screenshot -- Legend popup

The column titles should read, "Property types" and "Object types" (without plural for the first noun)

[Mikhail Naganov]

Created attachment 84392 [details]
patch

[Pavel Feldman]

Comment on attachment 84392 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84392&action=review

> Source/WebCore/bindings/v8/ScriptHeapSnapshot.h:62
> +    int getExactRetainedSize(uint64_t nodeId);

exactRetainedSize

> Source/WebCore/inspector/front-end/DetailedHeapshotView.js:118
> +    _getSortFields: function(sortColumn, sortAscending)

_sortFields

> Source/WebCore/inspector/front-end/DetailedHeapshotView.js:746
> +        if (this.views[this.views.current] === "Containment") {

Are you comparing to localized strings?

[Early Warning System Bot]

Attachment 84392 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8071874

[Mikhail Naganov]

Created attachment 84404 [details]
addressed comments and fixed JSC binding

[Mikhail Naganov]

(In reply to comment #7)
> (In reply to comment #6)
> > Created an attachment (id=84390) [details] [details]
> > Screenshot -- Legend popup
> 
> The column titles should read, "Property types" and "Object types" (without plural for the first noun)

Fixed

[Mikhail Naganov]

(In reply to comment #9)
> (From update of attachment 84392 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84392&action=review
> 
> > Source/WebCore/bindings/v8/ScriptHeapSnapshot.h:62
> > +    int getExactRetainedSize(uint64_t nodeId);
> 
> exactRetainedSize
> 

Fixed

> > Source/WebCore/inspector/front-end/DetailedHeapshotView.js:118
> > +    _getSortFields: function(sortColumn, sortAscending)
> 
> _sortFields
> 

Fixed

> > Source/WebCore/inspector/front-end/DetailedHeapshotView.js:746
> > +        if (this.views[this.views.current] === "Containment") {
> 
> Are you comparing to localized strings?

No. 'views' contains non-localized strings. See DetailedHeapShotview.js:404

[Mikhail Naganov]

Created attachment 84409 [details]
now --binary diff

[Mikhail Naganov]

Manually committed as http://trac.webkit.org/changeset/80135

2011-03-02  Mikhail Naganov  <[e-mail]>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Landing detailed heap snapshots, part 4.
        https://bugs.webkit.org/show_bug.cgi?id=55563

        This part adds implementations for data grids used to display
        different heap snapshots projections. We are almost done.

        * English.lproj/localizedStrings.js:
        * WebCore.gypi:
        * bindings/v8/ScriptHeapSnapshot.cpp:
        (WebCore::ScriptHeapSnapshot::getExactRetainedSize):
        * bindings/v8/ScriptHeapSnapshot.h:
        * inspector/Inspector.idl:
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::getExactHeapSnapshotNodeRetainedSize):
        * inspector/InspectorProfilerAgent.h:
        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotObjectNode):
        (WebInspector.HeapSnapshotObjectNode.prototype._createProvider):
        (WebInspector.HeapSnapshotInstanceNode):
        (WebInspector.HeapSnapshotInstanceNode.prototype._createProvider):
        (WebInspector.HeapSnapshotDominatorObjectNode):
        (WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
        (MixInSnapshotNodeFunctions):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotContainmentDataGrid):
        (WebInspector.HeapSnapshotSortableDataGrid):
        (WebInspector.HeapSnapshotConstructorsDataGrid):
        (WebInspector.HeapSnapshotDiffDataGrid):
        (WebInspector.HeapSnapshotDominatorsDataGrid):
        (WebInspector.HeapSnapshotRetainingPathsList):
        (WebInspector.DetailedHeapshotView.profileCallback):
        (WebInspector.DetailedHeapshotView):
        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshotEdge.prototype.get isInvisible):
        (WebInspector.HeapSnapshotEdge.prototype.toString):
        (WebInspector.HeapSnapshot.prototype._init):
        (WebInspector.HeapSnapshot.prototype._buildAggregatesIndexes):
        (WebInspector.HeapSnapshot.prototype._markInvisibleEdges):
        (WebInspector.HeapSnapshotPathFinder.prototype._skipEdge):
        * inspector/front-end/Images/helpButtonGlyph.png: Added.
        * inspector/front-end/Panel.js:
        (WebInspector.Panel.prototype.reset):
        * inspector/front-end/Popover.js:
        (WebInspector.Popover):
        (WebInspector.Popover.prototype.show):
        (WebInspector.Popover.prototype.hide):
        (WebInspector.Popover.prototype.get visible):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._reset):
        (WebInspector.ProfilesPanel.prototype.getProfile):
        * inspector/front-end/heapProfiler.css:
        * inspector/front-end/inspector.js:
        (WebInspector.resetFocusElement):