Bug 55553 - When displaying the missing plug-in sheet, pass the 'pluginspage' attribute to the UI process.
Summary: When displaying the missing plug-in sheet, pass the 'pluginspage' attribute t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-03-01 22:54 PST by Andy Estes
Modified: 2011-03-03 16:45 PST (History)
0 users

See Also:


Attachments
Patch (8.81 KB, patch)
2011-03-01 23:15 PST, Andy Estes
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2011-03-01 22:54:37 PST
When displaying the missing plug-in sheet, pass the 'pluginspage' attribute to the UI process.
Comment 1 Andy Estes 2011-03-01 23:15:12 PST
Created attachment 84371 [details]
Patch
Comment 2 Andy Estes 2011-03-01 23:18:49 PST
<rdar://problem/9057876>
Comment 3 Darin Adler 2011-03-02 16:36:29 PST
Comment on attachment 84371 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84371&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:461
> +    m_page->send(Messages::WebPageProxy::MissingPluginButtonClicked(pluginElement->serviceType(), pluginElement->url(), pluginElement->getAttribute("pluginspage")));

For better performance, this should be:

    fastGetAttribute(pluginspageAttr);

And that might require exporting another symbol.
Comment 4 Andy Estes 2011-03-02 16:43:57 PST
(In reply to comment #3)
> (From update of attachment 84371 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84371&action=review
> 
> > Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:461
> > +    m_page->send(Messages::WebPageProxy::MissingPluginButtonClicked(pluginElement->serviceType(), pluginElement->url(), pluginElement->getAttribute("pluginspage")));
> 
> For better performance, this should be:
> 
>     fastGetAttribute(pluginspageAttr);
> 
> And that might require exporting another symbol.

Thanks for the review! Will do.
Comment 5 Andy Estes 2011-03-03 16:45:50 PST
Committed <http://trac.webkit.org/changeset/80297>.