EventQueue needs to be ref counted
Created attachment 84302 [details] Patch
Please review.
Comment on attachment 84302 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84302&action=review > Source/WebCore/dom/EventQueue.cpp:94 > + RefPtr<EventQueue> m_keepAliveDuringIteration = this; RefPtr<EventQueue> protector(this) is a more common pattern for this: https://www.google.com/codesearch?as_q=refptr.*protector&vert=chromium Either way the name shouldn't start with m_ since it's not a member.
(In reply to comment #3) > (From update of attachment 84302 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=84302&action=review > > > Source/WebCore/dom/EventQueue.cpp:94 > > + RefPtr<EventQueue> m_keepAliveDuringIteration = this; > > RefPtr<EventQueue> protector(this) is a more common pattern for this: > https://www.google.com/codesearch?as_q=refptr.*protector&vert=chromium > > Either way the name shouldn't start with m_ since it's not a member. Oops...fixed.
Created attachment 84313 [details] Patch
Committed r80054: <http://trac.webkit.org/changeset/80054>
http://trac.webkit.org/changeset/80054 might have broken Chromium Win Release