Bug 55510 - Add feature define for data transfer items
Summary: Add feature define for data transfer items
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 55547
Blocks:
  Show dependency treegraph
 
Reported: 2011-03-01 14:47 PST by Daniel Cheng
Modified: 2011-03-02 14:24 PST (History)
5 users (show)

See Also:


Attachments
Patch (17.96 KB, patch)
2011-03-01 14:55 PST, Daniel Cheng
no flags Details | Formatted Diff | Diff
Patch (26.56 KB, patch)
2011-03-02 14:20 PST, Daniel Cheng
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Cheng 2011-03-01 14:47:09 PST
Add feature define for data transfer items
Comment 1 Daniel Cheng 2011-03-01 14:55:34 PST
Created attachment 84299 [details]
Patch
Comment 2 David Levin 2011-03-01 15:24:13 PST
Comment on attachment 84299 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84299&action=review

One minor nit.

> Source/WebKit/chromium/features.gypi:52
> +        'ENABLE_DATA_TRANSFER_ITEMS=0',

Set it to 1 for chromium. You just need to be sure to guard the entry points in idl with the runtime enabling.
Comment 3 Daniel Cheng 2011-03-01 18:16:01 PST
Committed r80079: <http://trac.webkit.org/changeset/80079>
Comment 4 WebKit Review Bot 2011-03-01 18:35:49 PST
http://trac.webkit.org/changeset/80079 might have broken Windows Debug (Build)
Comment 5 Daniel Cheng 2011-03-02 14:20:52 PST
Created attachment 84466 [details]
Patch
Comment 6 Daniel Cheng 2011-03-02 14:24:10 PST
Committed r80166: <http://trac.webkit.org/changeset/80166>