Bug 55494 - Rebaseline of a layout test due to antialiasing issue for leopard/snowleopard
Summary: Rebaseline of a layout test due to antialiasing issue for leopard/snowleopard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-01 12:24 PST by imasaki
Modified: 2011-03-03 10:58 PST (History)
6 users (show)

See Also:

Attachments
Patch (81.15 KB, patch)
2011-03-01 12:28 PST, imasaki 		no flags Details | Formatted Diff | Diff
Patch (81.15 KB, patch)
2011-03-01 13:05 PST, imasaki 		no flags Details | Formatted Diff | Diff
Patch (160.88 KB, patch)
2011-03-02 18:01 PST, imasaki 		no flags Details | Formatted Diff | Diff
Patch (80.75 KB, patch)
2011-03-02 18:19 PST, imasaki 		no flags Details | Formatted Diff | Diff
Patch (239.86 KB, patch)
2011-03-03 10:07 PST, imasaki 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description imasaki 2011-03-01 12:24:03 PST 
Rebaseline of a layout test due to antialiasing issue for leopard/snowleopard
Comment 1 imasaki 2011-03-01 12:28:37 PST 
Created attachment 84272 [details]
Patch
Comment 2 imasaki 2011-03-01 13:05:52 PST 
Created attachment 84279 [details]
Patch
Comment 3 Mihai Parparita 2011-03-02 17:43:48 PST 
Comment on attachment 84279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84279&action=review

> LayoutTests/ChangeLog:13
> +        * platform/chromium-mac-snowleopard/media/video-layer-crash-expected.checksum: Renamed from LayoutTests/platform/chromium-mac/media/video-layer-crash-expected.checksum.

Snow Leopard baselines should go in platform/chromium-mac (see https://groups.google.com/a/google.com/group/chrome-webkit-gardening/browse_thread/thread/224d2c64f017e333).

Also, this file move doesn't get uploaded correctly by webkit-patch due to https://bugs.webkit.org/show_bug.cgi?id=49154. If you don't have committer access you'll need to have someone else land this for you.
Comment 4 imasaki 2011-03-02 18:01:12 PST 
Created attachment 84502 [details]
Patch
Comment 5 WebKit Review Bot 2011-03-02 18:03:13 PST 
Attachment 84502 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

LayoutTests/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 imasaki 2011-03-02 18:19:31 PST 
Created attachment 84503 [details]
Patch
Comment 7 Mihai Parparita 2011-03-02 21:27:05 PST 
Comment on attachment 84503 [details]
Patch

Actually, now that I've looked at the current results (http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showAllRuns=true&tests=media%2Fvideo-layer-crash.html&group=%40ToT%20-%20chromium.org) and patched this in, I'm not sure I understand this change.

As far as I can tell, the test is currently passing everywhere except on 10.6 (Snow Leopard). The patch currently only adds chromium-mac-leopard baselines, which won't help with that. I think the correct things to do would be to:
1) Move the current chromium-mac baselines (which are valid for Leopard only) to chromium-mac-leopard
2) Add new Snow Leopard baselines to chromium-mac
3) Remove the media/video-layer-crash.html lines from test_expectations.txt (both the MAC and LINUX ones)

Sorry if I'm misunderstanding anything, feel free to ping me in #webkit or on IM.
Comment 8 imasaki 2011-03-03 10:07:26 PST 
Created attachment 84579 [details]
Patch
Comment 9 WebKit Commit Bot 2011-03-03 10:58:04 PST 
Comment on attachment 84579 [details]
Patch

Clearing flags on attachment: 84579

Committed r80259: <http://trac.webkit.org/changeset/80259>
Comment 10 WebKit Commit Bot 2011-03-03 10:58:10 PST 
All reviewed patches have been landed.  Closing bug.