Bug 55489 - Web Inspector: Searching on the Network panel doesn't do anything?
Summary: Web Inspector: Searching on the Network panel doesn't do anything?
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
: 56398 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-03-01 11:49 PST by Matt Lilek
Modified: 2011-07-07 05:07 PDT (History)
13 users (show)

See Also:


Attachments
[patch] initial version (7.87 KB, patch)
2011-07-04 09:59 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
[patch] initial version. Unnecessary logging was removed. (7.83 KB, patch)
2011-07-04 10:01 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
[patch] initial version. with styles fixes. (7.31 KB, patch)
2011-07-04 10:12 PDT, Ilya Tikhonovsky
pfeldman: review-
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-02 (2.12 MB, application/zip)
2011-07-04 10:38 PDT, WebKit Review Bot
no flags Details
[patch] initial version (8.59 KB, patch)
2011-07-06 02:07 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
[patch] third version (8.60 KB, patch)
2011-07-06 04:13 PDT, Ilya Tikhonovsky
yurys: review-
Details | Formatted Diff | Diff
[patch] fourth version (8.72 KB, patch)
2011-07-06 05:48 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
[patch] fifth version (10.02 KB, patch)
2011-07-06 09:41 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
[patch] next iteration. (10.28 KB, patch)
2011-07-07 01:32 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lilek 2011-03-01 11:49:30 PST
Is searching supposed to work on the Network panel?

I tried to search for a phrase in content and nothing happens.  When that didn't turn up anything, I thought maybe it only worked on file names - nope.  Selected a file (the index page of webkit.org), switched to the content tab and it doesn't work on that either.
Comment 1 Matt Lilek 2011-03-30 16:17:00 PDT
*** Bug 56398 has been marked as a duplicate of this bug. ***
Comment 2 Ilya Tikhonovsky 2011-07-04 09:59:57 PDT
Created attachment 99639 [details]
[patch] initial version
Comment 3 Ilya Tikhonovsky 2011-07-04 10:01:17 PDT
Created attachment 99640 [details]
[patch] initial version. Unnecessary logging was removed.
Comment 4 WebKit Review Bot 2011-07-04 10:01:29 PDT
Attachment 99639 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Review Bot 2011-07-04 10:04:53 PDT
Attachment 99640 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Ilya Tikhonovsky 2011-07-04 10:12:41 PDT
Created attachment 99642 [details]
[patch] initial version. with styles fixes.
Comment 7 WebKit Review Bot 2011-07-04 10:37:57 PDT
Comment on attachment 99642 [details]
[patch] initial version. with styles fixes.

Attachment 99642 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8988025

New failing tests:
inspector/audits/audits-panel-functional.html
http/tests/inspector/resource-tree/resource-tree-mimetype.html
inspector/elements/elements-panel-selection-on-refresh.html
inspector/console/console-log-toString-object.html
inspector/console/console-preserve-log.html
inspector/debugger/debugger-reload-on-pause.html
inspector/console/alert-toString-exception.html
inspector/debugger/dom-breakpoints.html
inspector/debugger/debugger-breakpoints-not-activated-on-reload.html
inspector/console/console-uncaught-exception-in-eval.html
http/tests/inspector/resource-har-conversion.html
http/tests/inspector/resource-tree/resource-tree-reload.html
Comment 8 WebKit Review Bot 2011-07-04 10:38:03 PDT
Created attachment 99646 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 9 Pavel Feldman 2011-07-05 01:51:19 PDT
Comment on attachment 99642 [details]
[patch] initial version. with styles fixes.

View in context: https://bugs.webkit.org/attachment.cgi?id=99642&action=review

> Source/WebCore/inspector/front-end/NetworkPanel.js:1097
> +        if (!(resource._displayName && resource._displayName.match(this._searchRegExp)) &&

Checking path is sufficient.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1101
> +        if (resource.identifier in this._matchedResourcesIdMap) {

no need for {}

> Source/WebCore/inspector/front-end/NetworkPanel.js:1107
> +        node._addStyleClass("search-matched-item");

See highlightSearchResult in utilities.js and its usages on how to highlight search match.
Comment 10 Vsevolod Vlasov 2011-07-05 06:45:29 PDT
Comment on attachment 99642 [details]
[patch] initial version. with styles fixes.

View in context: https://bugs.webkit.org/attachment.cgi?id=99642&action=review

> Source/WebCore/inspector/front-end/NetworkPanel.js:1105
> +        this._matchedResourcesMap[resource.identifier] = true;

Looks like this field is not used anywhere else, is it needed?

> Source/WebCore/inspector/front-end/NetworkPanel.js:1157
> +        this._searchRegExp = new RegExp(searchQuery,"i");

Please use createSearchRegex() from utilities.js here.

> Source/WebCore/inspector/front-end/NetworkPanel.js:1170
> +        if (!this._matchedResources.length)

I can't find any place where this._matchedResources is updated.
Comment 11 Ilya Tikhonovsky 2011-07-06 02:07:40 PDT
Created attachment 99803 [details]
[patch] initial version
Comment 12 Ilya Tikhonovsky 2011-07-06 04:13:34 PDT
Created attachment 99814 [details]
[patch] third version

"new RegExp" was replaced with createSearchRegexp
Comment 13 Yury Semikhatsky 2011-07-06 04:35:03 PDT
Comment on attachment 99814 [details]
[patch] third version

r- until the UI issues are not resolved.
Comment 14 Ilya Tikhonovsky 2011-07-06 05:48:22 PDT
Created attachment 99819 [details]
[patch] fourth version

It is toggle large view only when the highlighted element has matches only in the path section.
Comment 15 Ilya Tikhonovsky 2011-07-06 09:41:01 PDT
Created attachment 99844 [details]
[patch] fifth version

it supports sorting and filtering
Comment 16 Pavel Feldman 2011-07-06 10:04:46 PDT
Comment on attachment 99844 [details]
[patch] fifth version

View in context: https://bugs.webkit.org/attachment.cgi?id=99844&action=review

> Source/WebCore/inspector/front-end/NetworkPanel.js:1105
> +            if (!refresh)

Should matcher be refresh-aware?
Comment 17 Ilya Tikhonovsky 2011-07-07 01:32:25 PDT
Created attachment 99956 [details]
[patch] next iteration.

_updateHighlightIfMatched was extracted from _matchResource
Comment 18 Ilya Tikhonovsky 2011-07-07 05:06:42 PDT
Comment on attachment 99956 [details]
[patch] next iteration.

Clearing flags on attachment: 99956

Committed r90556: <http://trac.webkit.org/changeset/90556>
Comment 19 Ilya Tikhonovsky 2011-07-07 05:07:01 PDT
All reviewed patches have been landed.  Closing bug.