Bug 55464 - Web Inspector: extract all code that depends on source mapping from SourceFrame
Summary: Web Inspector: extract all code that depends on source mapping from SourceFrame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-01 05:57 PST by Pavel Podivilov
Modified: 2011-03-04 09:17 PST (History)
13 users (show)

See Also:


Attachments
Patch. (27.53 KB, patch)
2011-03-01 05:58 PST, Pavel Podivilov
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-03-01 05:57:58 PST
Web Inspector: extract all code that depends on source mapping from SourceFrame.

Extract all dependencies on DebuggerModel and ScriptsPanel to a delegate class to encapsulate source mapping aspects from SourceFrame.
Comment 1 Pavel Podivilov 2011-03-01 05:58:59 PST
Created attachment 84221 [details]
Patch.
Comment 2 Yury Semikhatsky 2011-03-03 09:14:06 PST
Comment on attachment 84221 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=84221&action=review

> Source/WebCore/inspector/front-end/ScriptsPanel.js:1072
> +            var delegate = new WebInspector.SourceFrameDelegateForResourcesPanel(this._script.resource);

This looks very odd. The delegate should be called by the SourceFrame. Common functionality of the delegates could either be provided by their superclass or moved into an utility function.
Comment 3 Pavel Podivilov 2011-03-04 08:41:32 PST
Committed r80356: <http://trac.webkit.org/changeset/80356>
Comment 4 WebKit Review Bot 2011-03-04 09:17:12 PST
http://trac.webkit.org/changeset/80356 might have broken Qt Linux Release
The following tests are not passing:
http/tests/inspector/console-xhr-logging.html
http/tests/inspector/network-preflight-options.html
http/tests/inspector/resource-parameters.html
inspector/console/command-line-api-inspect.html
inspector/console/command-line-api.html
inspector/console/console-api-on-call-frame.html
inspector/console/console-assert.html
inspector/console/console-command-clear.html
inspector/console/console-eval-global.html
inspector/console/console-eval.html
inspector/console/console-format.html
inspector/console/console-substituted.html
inspector/cpu-profiler-profiling.html
inspector/debugger/debug-inlined-scripts.html
inspector/debugger/debugger-autocontinue-on-syntax-error.html
inspector/debugger/debugger-scripts.html
inspector/debugger/debugger-suspend-active-dom-objects.html
inspector/debugger/scripts-panel.html
inspector/debugger/source-frame.html
inspector/elements/elements-img-tooltip.html
inspector/elements/elements-panel-limited-children.html
inspector/elements/elements-panel-styles.html
inspector/extensions/extensions-resources.html
inspector/storage-panel-dom-storage.html
inspector/styles/styles-computed-trace.html
inspector/styles/styles-disable-inherited.html
inspector/timeline/timeline-event-dispatch.html
inspector/timeline/timeline-mark-timeline.html
inspector/timeline/timeline-script-tag-2.html