Bug 55460 – [EFL] New mediaControl css file for EFL

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

We need to make new mediaControl file for EFL port. Layout of media controller is decided by the mediaControl file. So, I make it referencing to mediaControls.css.

[Gyuyoung Kim]

Created attachment 84216 [details]
Proposed Patch

[Lucas De Marchi]

Comment on attachment 84216 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84216&action=review

> Source/WebCore/CMakeLists.txt:1544
>  SET(WebCore_USER_AGENT_STYLE_SHEETS
>      ${WEBCORE_DIR}/css/html.css
>      ${WEBCORE_DIR}/css/mathml.css
>      ${WEBCORE_DIR}/css/mediaControls.css
> -    ${WEBCORE_DIR}/css/mediaControlsGtk.css
> +    ${WEBCORE_DIR}/css/mediaControlsEfl.css

Shouldn't this be part of WebCore/CMakeListsEfl.txt?

[Gyuyoung Kim]

(In reply to comment #2)
> (From update of attachment 84216 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84216&action=review
> 
> > Source/WebCore/CMakeLists.txt:1544
> >  SET(WebCore_USER_AGENT_STYLE_SHEETS
> >      ${WEBCORE_DIR}/css/html.css
> >      ${WEBCORE_DIR}/css/mathml.css
> >      ${WEBCORE_DIR}/css/mediaControls.css
> > -    ${WEBCORE_DIR}/css/mediaControlsGtk.css
> > +    ${WEBCORE_DIR}/css/mediaControlsEfl.css
> 
> Shouldn't this be part of WebCore/CMakeListsEfl.txt?

If I move it to CMakeListEfl.txt, the UserAgentStyleSheets.h file doesn't include "mediaControlsEflUserAgentStyleSheet" used by RenderThemeEfl.cpp. Because, CMakeLists.txt generates the UserAgentStyleSheets.h, UserAgentStyleSheets.h can't include mediaControlsEfl.css.

CMakeLists.h
...
2204 # Generate user agent styles
2205 ADD_CUSTOM_COMMAND(
2206     OUTPUT ${DERIVED_SOURCES_DIR}/UserAgentStyleSheetsData.cpp ${DERIVED_SOURCES_DIR}/UserAgentStyleSheets.h
2207     MAIN_DEPENDENCY ${WEBCORE_DIR}/css/make-css-file-arrays.pl
2208     DEPENDS ${WebCore_USER_AGENT_STYLE_SHEETS}
2209     COMMAND ${PERL_EXECUTABLE} ${WEBCORE_DIR}/css/make-css-file-arrays.pl ${DERIVED_SOURCES_DIR}/UserAgentStyleSheets.h ${DERIVED_SOURCES_DIR}/UserAgentStyleSheetsData.cpp ${WebCo     re_USER_AGENT_STYLE_SHEETS}
2210     VERBATIM)
2211 LIST(APPEND WebCore_SOURCES ${DERIVED_SOURCES_DIR}/UserAgentStyleSheetsData.cpp)
2212 ADD_SOURCE_DERIVED_DEPENDENCIES(${WEBCORE_DIR}/css/CSSStyleSelector.cpp UserAgentStyleSheetsData.cpp UserAgentStyleSheets.h)
2213

[Gyuyoung Kim]

(In reply to comment #3)

> 
> CMakeLists.h

Oops. I mean CMakeLists.txt file.

[Gyuyoung Kim]

I need this patch to add media control UI. WebKit EFL doesn't display any media control buttons now. Please review this patch.

[WebKit Commit Bot]

Comment on attachment 84216 [details]
Proposed Patch

Rejecting attachment 84216 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 1

Last 500 characters of output:
rks/Python.framework/Versions/2.6/lib/python2.6/urllib2.py", line 361, in _call_chain
    result = func(*args)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_http.py", line 756, in https_open
    return self.do_open(conn_factory, req)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_http.py", line 706, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://queues.webkit.org/results/8110932

[Eric Seidel (no email)]

Comment on attachment 84216 [details]
Proposed Patch

This is the second time we've seen bugzilla attachment fetching time out in the last 24 hours.  Perhaps Bill has been restarting servers?  Obviously we could make webkit-patch more robust against this type of failure (And probably should!)

[Gyuyoung Kim]

Comment on attachment 84216 [details]
Proposed Patch

Changelog is wrong.

[Gyuyoung Kim]

Created attachment 85264 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 85264 [details]
Patch

Clearing flags on attachment: 85264

Committed r80809: <http://trac.webkit.org/changeset/80809>