Bug 55442 – webarchives don't contain subframe content

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Alice Liu]

WebPage::getWebArchiveOfFrame doesn't seem to generate any content for subframes in the resulting webarchive. 

This is because we're calling the wrong LegacyWebArchive::create() function (there are 7).  We're calling the one that takes a Frame* whereas we should be calling the one that takes a Node*.  Doing so will match old WebKit behaviour in -[DOMNode(WebDOMNodeOperations) webArchive] 

steps to repro: 
1) create a webarchive for your facebook.com (logged in) homepage. 

<rdar://problem/8994125>

[Alice Liu]

Created attachment 84175 [details]
patch

Brady Eidson (beidson) has approved this change in-person.

[Gavin Barraclough]

Comment on attachment 84175 [details]
patch

r+ since this changes behaviour to match webkit1.  But it seems like LegacyWebArchive::create should have the same behaviour whether it is passed the frame or the document I think this is likely either a bug, or a case for a function to be renamed to make this clearer.  We should probably open a new bug to track this issue.

[Alice Liu]

I filed https://bugs.webkit.org/show_bug.cgi?id=55445

[Alice Liu]

committed http://trac.webkit.org/changeset/79965