Bug 55437 – [GTK] Convert use of cairo_t to RefPtr<cairo_t> in webkitwebiew.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Joone Hur]

When we create a cairo context through gdk_cairo_create, we need to use RefPtr instead of raw pointer.

[Joone Hur]

Created attachment 84174 [details]
Proposed Patch

[Martin Robinson]

Comment on attachment 84174 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84174&action=review

Great. Thanks!

> Source/WebKit/gtk/ChangeLog:10
> +        Convert use of cairo_t to RefPtr<cairo_t>
> +
> +        [GTK] Convert use of cairo_t to RefPtr<cairo_t> in webkitwebiew.cpp
> +        https://bugs.webkit.org/show_bug.cgi?id=55437
> +
> +        * webkit/webkitwebview.cpp:

I'd move the first description to after webkit/webkitwebview.cpp:

[Joone Hur]

Created attachment 84187 [details]
Updated ChangeLog

Thanks, Martin!

[WebKit Commit Bot]

Comment on attachment 84187 [details]
Updated ChangeLog

Rejecting attachment 84187 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 1

Last 500 characters of output:

Processing 1 patch from 1 bug.
Cleaning working directory
Updating working directory
Processing patch 84187 from bug 55437.
NOBODY (OOPS!) found in /mnt/git/webkit-commit-queue/Source/WebKit/gtk/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/gtk/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Updating OpenSource
Current branch master is up to date.

Full output: http://queues.webkit.org/results/8071550

[Joone Hur]

Created attachment 84197 [details]
Updated ChangeLog with reviewer name

I missed reviewer name.

[WebKit Commit Bot]

Comment on attachment 84197 [details]
Updated ChangeLog with reviewer name

Clearing flags on attachment: 84197

Committed r79977: <http://trac.webkit.org/changeset/79977>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.