Bug 55437 - [GTK] Convert use of cairo_t to RefPtr<cairo_t> in webkitwebiew.cpp
Summary: [GTK] Convert use of cairo_t to RefPtr<cairo_t> in webkitwebiew.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-28 18:52 PST by Joone Hur
Modified: 2011-03-01 00:46 PST (History)
3 users (show)

See Also:

Attachments
Proposed Patch (1.34 KB, patch)
2011-02-28 19:31 PST, Joone Hur 		mrobinson: review+
Details | Formatted Diff | Diff
Updated ChangeLog (1.33 KB, patch)
2011-02-28 22:06 PST, Joone Hur 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Updated ChangeLog with reviewer name (1.33 KB, patch)
2011-03-01 00:26 PST, Joone Hur 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joone Hur 2011-02-28 18:52:28 PST 
When we create a cairo context through gdk_cairo_create, we need to use RefPtr instead of raw pointer.
Comment 1 Joone Hur 2011-02-28 19:31:07 PST 
Created attachment 84174 [details]
Proposed Patch
Comment 2 Martin Robinson 2011-02-28 19:40:38 PST 
Comment on attachment 84174 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84174&action=review

Great. Thanks!

> Source/WebKit/gtk/ChangeLog:10
> +        Convert use of cairo_t to RefPtr<cairo_t>
> +
> +        [GTK] Convert use of cairo_t to RefPtr<cairo_t> in webkitwebiew.cpp
> +        https://bugs.webkit.org/show_bug.cgi?id=55437
> +
> +        * webkit/webkitwebview.cpp:

I'd move the first description to after webkit/webkitwebview.cpp:
Comment 3 Joone Hur 2011-02-28 22:06:31 PST 
Created attachment 84187 [details]
Updated ChangeLog

Thanks, Martin!
Comment 4 WebKit Commit Bot 2011-02-28 23:31:58 PST 
Comment on attachment 84187 [details]
Updated ChangeLog

Rejecting attachment 84187 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 1

Last 500 characters of output:

Processing 1 patch from 1 bug.
Cleaning working directory
Updating working directory
Processing patch 84187 from bug 55437.
NOBODY (OOPS!) found in /mnt/git/webkit-commit-queue/Source/WebKit/gtk/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/gtk/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Updating OpenSource
Current branch master is up to date.

Full output: http://queues.webkit.org/results/8071550
Comment 5 Joone Hur 2011-03-01 00:26:29 PST 
Created attachment 84197 [details]
Updated ChangeLog with reviewer name

I missed reviewer name.
Comment 6 WebKit Commit Bot 2011-03-01 00:46:38 PST 
Comment on attachment 84197 [details]
Updated ChangeLog with reviewer name

Clearing flags on attachment: 84197

Committed r79977: <http://trac.webkit.org/changeset/79977>
Comment 7 WebKit Commit Bot 2011-03-01 00:46:43 PST 
All reviewed patches have been landed.  Closing bug.