Bug 55436 – No shadow when stroking a path with a gradient

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Helder Correia]

This happens in CG and is related to bug 52509, this time to be fixed in GraphicsContext::strokePath(). The gradient needs to be drawn clipped to the stroke on a CGLayer first, then the layer drawn on the GraphicsContext.

[Helder Correia]

Created attachment 84170 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 84170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84170&action=review

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:616
> +            const FloatRect rect = path.boundingRect();
> +            const float lineWidth = strokeThickness();
> +            const float doubleLineWidth = lineWidth * 2;
> +            const float layerWidth = ceilf(rect.width() + doubleLineWidth);
> +            const float layerHeight = ceilf(rect.height() + doubleLineWidth);

It's not really customary to use const for local variables; just follow the style in the rest of the file.

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:636
> +            const float destinationX = roundf(rect.x() - lineWidth);
> +            const float destinationY = roundf(rect.y() - lineWidth);

I don't think there's any point using 'const' for variables that are declared just before you use them.

[Helder Correia]

Manually committed r80049: http://trac.webkit.org/changeset/80049

[WebKit Review Bot]

http://trac.webkit.org/changeset/80049 might have broken Qt Linux Release
The following tests are not passing:
fast/canvas/canvas-strokePath-gradient-shadow.html

[Helder Correia]

(In reply to comment #4)
> http://trac.webkit.org/changeset/80049 might have broken Qt Linux Release
> The following tests are not passing:
> fast/canvas/canvas-strokePath-gradient-shadow.html

The manually committed patch didn't add
fast/canvas/canvas-strokePath-gradient-shadow.html to Qt Skipped by mistake. Fixed in http://trac.webkit.org/changeset/80069