Bug 55430 - OwnArrayPtr.h’s LOOSE_OWN_ARRAY_PTR mode results in code that does not link
Summary: OwnArrayPtr.h’s LOOSE_OWN_ARRAY_PTR mode results in code that does not link
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-28 17:03 PST by Mark Rowe (bdash)
Modified: 2011-02-28 17:56 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2011-02-28 17:11 PST, Mark Rowe (bdash) 		darin: review-
Details | Formatted Diff | Diff
Patch (1.74 KB, patch)
2011-02-28 17:19 PST, Mark Rowe (bdash) 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2011-02-28 17:03:27 PST 
OwnArrayPtr::set is lacking an implementation so using LOOSE_OWN_ARRAY_PTR results in code that doesn’t compile.
Comment 1 Mark Rowe (bdash) 2011-02-28 17:11:13 PST 
Created attachment 84159 [details]
Patch
Comment 2 Mark Rowe (bdash) 2011-02-28 17:12:23 PST 
Comment on attachment 84159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84159&action=review

> Source/JavaScriptCore/wtf/OwnArrayPtr.h:114
> +template<typename T> inline void OwnArrayPtr<T>::set(PtrType ptr)

This is obviously missing the necessary #ifdef.
Comment 3 Darin Adler 2011-02-28 17:16:58 PST 
Comment on attachment 84159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84159&action=review

> Source/JavaScriptCore/wtf/OwnArrayPtr.h:114
> +template<typename T> inline void OwnArrayPtr<T>::set(PtrType ptr)

Needs to be inside an #ifdef.
Comment 4 Mark Rowe (bdash) 2011-02-28 17:19:29 PST 
Created attachment 84160 [details]
Patch
Comment 5 WebKit Review Bot 2011-02-28 17:32:15 PST 
Attachment 84159 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8074436
Comment 6 Mark Rowe (bdash) 2011-02-28 17:56:00 PST 
Landed in r79955.