RESOLVED FIXED 55424
Stop using DeprecatedPtr for the global exception slot 
https://bugs.webkit.org/show_bug.cgi?id=55424
Summary Stop using DeprecatedPtr for the global exception slot
Oliver Hunt
Reported 2011-02-28 16:12:22 PST
Stop using DeprecatedPtr for the global exception slot
Attachments
Patch (2.78 KB, patch)
2011-02-28 16:17 PST, Oliver Hunt 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-02-28 16:17:09 PST
Created attachment 84146 [details] Patch
Darin Adler
Comment 2 2011-02-28 16:22:07 PST
Comment on attachment 84146 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84146&action=review > Source/JavaScriptCore/runtime/WriteBarrier.h:154 > +template <typename T> class GCRootPtr : public WriteBarrierBase<T> { I’ve been using: template<typename T> without the space after template, by analogy with the lack of space after a function name before its arguments. Just sayin’. > Source/JavaScriptCore/runtime/WriteBarrier.h:159 > + this->setWithoutWriteBarrier(value); Why all this use of this? Wouldn’t it compile without it?
Gavin Barraclough
Comment 3 2011-02-28 16:33:11 PST
Comment on attachment 84146 [details] Patch looks sensible
Oliver Hunt
Comment 4 2011-02-28 17:10:12 PST
Committed r79948: <http://trac.webkit.org/changeset/79948>
Geoffrey Garen
Comment 5 2011-02-28 17:13:52 PST
Why not just use Global<T>? What's the difference between Global<T> and GCRootPtr<T>? How do I know which one to use?
Xan Lopez
Comment 6 2011-02-28 18:46:40 PST
This might have broken some layout tests in a bunch of platforms, including SL.
WebKit Review Bot
Comment 7 2011-02-28 21:14:37 PST
http://trac.webkit.org/changeset/79948 might have broken GTK Linux 64-bit Debug
Note You need to log in before you can comment on or make changes to this bug.