Bug 55424 - Stop using DeprecatedPtr for the global exception slot
Summary: Stop using DeprecatedPtr for the global exception slot
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
Depends on: 55439
  Show dependency treegraph
Reported: 2011-02-28 16:12 PST by Oliver Hunt
Modified: 2011-02-28 21:14 PST (History)
5 users (show)

See Also:

Patch (2.78 KB, patch)
2011-02-28 16:17 PST, Oliver Hunt
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-02-28 16:12:22 PST
Stop using DeprecatedPtr for the global exception slot
Comment 1 Oliver Hunt 2011-02-28 16:17:09 PST
Created attachment 84146 [details]
Comment 2 Darin Adler 2011-02-28 16:22:07 PST
Comment on attachment 84146 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=84146&action=review

> Source/JavaScriptCore/runtime/WriteBarrier.h:154
> +template <typename T> class GCRootPtr : public WriteBarrierBase<T> {

I’ve been using:

    template<typename T>

without the space after template, by analogy with the lack of space after a function name before its arguments. Just sayin’.

> Source/JavaScriptCore/runtime/WriteBarrier.h:159
> +        this->setWithoutWriteBarrier(value);

Why all this use of this? Wouldn’t it compile without it?
Comment 3 Gavin Barraclough 2011-02-28 16:33:11 PST
Comment on attachment 84146 [details]

looks sensible
Comment 4 Oliver Hunt 2011-02-28 17:10:12 PST
Committed r79948: <http://trac.webkit.org/changeset/79948>
Comment 5 Geoffrey Garen 2011-02-28 17:13:52 PST
Why not just use Global<T>?

What's the difference between Global<T> and GCRootPtr<T>? How do I know which one to use?
Comment 6 Xan Lopez 2011-02-28 18:46:40 PST
This might have broken some layout tests in a bunch of platforms, including SL.
Comment 7 WebKit Review Bot 2011-02-28 21:14:37 PST
http://trac.webkit.org/changeset/79948 might have broken GTK Linux 64-bit Debug