Bug 55419 - IDBKeyRange.bound() should not use the optional options object
Summary: IDBKeyRange.bound() should not use the optional options object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Jeremy Orlow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-28 15:32 PST by Jeremy Orlow
Modified: 2011-03-01 18:02 PST (History)
7 users (show)

See Also:


Attachments
Patch (10.71 KB, patch)
2011-02-28 15:33 PST, Jeremy Orlow
no flags Details | Formatted Diff | Diff
Patch (10.70 KB, patch)
2011-03-01 12:49 PST, Jeremy Orlow
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2011-02-28 15:32:38 PST
IDBKeyRange.bound() should not use the optional options object
Comment 1 Jeremy Orlow 2011-02-28 15:33:18 PST
Created attachment 84135 [details]
Patch
Comment 2 Jeremy Orlow 2011-03-01 12:35:43 PST
This moves us back in line with the spec.
Comment 3 Jeremy Orlow 2011-03-01 12:49:53 PST
Created attachment 84278 [details]
Patch
Comment 4 David Grogan 2011-03-01 12:56:40 PST
Unofficial LGTM.

This is indeed what the spec says and I checked for absent-minded-type mistakes we all make.  Just look over for style.
Comment 5 James Robinson 2011-03-01 13:00:18 PST
Comment on attachment 84278 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84278&action=review

OK

> Source/WebCore/ChangeLog:8
> +        https://bugs.webkit.org/show_bug.cgi?id=55419
> +
> +        * storage/IDBKeyRange.cpp:

Can you add a reference to the relevant tests?  Link to spec text would be nice as well.
Comment 6 Jeremy Orlow 2011-03-01 13:02:41 PST
(In reply to comment #5)
> (From update of attachment 84278 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84278&action=review
> 
> OK
> 
> > Source/WebCore/ChangeLog:8
> > +        https://bugs.webkit.org/show_bug.cgi?id=55419
> > +
> > +        * storage/IDBKeyRange.cpp:
> 
> Can you add a reference to the relevant tests?  Link to spec text would be nice as well.

Will add http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#range-concept and a note about the existing tests that were updated.

Thanks.
Comment 7 Jeremy Orlow 2011-03-01 18:02:46 PST
Committed r80076: <http://trac.webkit.org/changeset/80076>