Bug 55392 - Follow HTML5 spec for document.open() a little more closely
Summary: Follow HTML5 spec for document.open() a little more closely
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks: 54355
  Show dependency treegraph
 
Reported: 2011-02-28 11:39 PST by Tony Gentilcore
Modified: 2011-02-28 18:07 PST (History)
4 users (show)

See Also:


Attachments
Patch (5.82 KB, patch)
2011-02-28 12:47 PST, Tony Gentilcore
no flags Details | Formatted Diff | Diff
Patch (5.77 KB, patch)
2011-02-28 13:15 PST, Tony Gentilcore
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2011-02-28 11:39:00 PST
Follow HTML5 spec for document.open() a little more closely
Comment 1 Tony Gentilcore 2011-02-28 12:47:15 PST
Created attachment 84100 [details]
Patch
Comment 2 Tony Gentilcore 2011-02-28 12:48:26 PST
Adam, this is the missing check for the script-created parser that we talked about on Friday.
Comment 3 Tony Gentilcore 2011-02-28 13:15:31 PST
Created attachment 84107 [details]
Patch
Comment 4 Adam Barth 2011-02-28 14:33:21 PST
Comment on attachment 84107 [details]
Patch

This looks like progress.  I'm glad we're doing this in small steps, but at some point we might need to make a more global change to make this state machine follow the spec (and sanity).
Comment 5 Tony Gentilcore 2011-02-28 14:36:44 PST
(In reply to comment #4)
> (From update of attachment 84107 [details])
> This looks like progress.  I'm glad we're doing this in small steps, but at some point we might need to make a more global change to make this state machine follow the spec (and sanity).

Yeah, agreed. That is going to be a hairy patch, though.
Comment 6 WebKit Commit Bot 2011-02-28 16:55:15 PST
Comment on attachment 84107 [details]
Patch

Clearing flags on attachment: 84107

Committed r79944: <http://trac.webkit.org/changeset/79944>
Comment 7 WebKit Commit Bot 2011-02-28 16:55:20 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 WebKit Review Bot 2011-02-28 18:07:48 PST
http://trac.webkit.org/changeset/79944 might have broken Qt Linux Release
The following tests are not passing:
fast/events/tabindex-focus-blur-all.html
fast/frames/iframe-plugin-load-remove-document-crash.html
fast/frames/sandboxed-iframe-attribute-parsing.html
fast/layers/clip-rects-transformed.html
fast/replaced/object-with-non-empty-classid-triggers-fallback.html
plugins/createScriptableObject-before-start.html
plugins/destroy-on-setwindow.html
plugins/destroy-plugin-from-callback.html
plugins/destroy-stream-twice.html
plugins/document-open.html
plugins/evaluate-js-after-removing-plugin-element.html
plugins/get-file-url.html
plugins/get-url-that-the-resource-load-delegate-will-disallow.html
plugins/get-url-with-javascript-destroying-plugin.html
plugins/geturl-replace-query.html
plugins/geturlnotify-during-document-teardown.html
plugins/instance-available-before-stylesheets-loaded-object.html
plugins/invalid-mime-with-valid-extension-shows-missing-plugin.html
plugins/js-from-destroy.html