Bug 55385 - Use Frame::ownerElement() directly where appropriate.
Summary: Use Frame::ownerElement() directly where appropriate.
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-02-28 09:00 PST by Andreas Kling
Modified: 2011-02-28 09:51 PST (History)
0 users

See Also:

Proposed patch (7.90 KB, patch)
2011-02-28 09:03 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-02-28 09:00:57 PST
Don't take the roundabout way through frame->document->ownerElement which just checks that the document->frame is non-null.
Comment 1 Andreas Kling 2011-02-28 09:03:06 PST
Created attachment 84069 [details]
Proposed patch
Comment 2 Darin Adler 2011-02-28 09:45:45 PST
Comment on attachment 84069 [details]
Proposed patch

Ideally we’d remove redundant functions like these. It’s annoying to have the same function in both Document and Frame. We have many cases of this. Obviously we don’t want to go from Frame to Document and then have it just call back to Frame so this change is great given the current state of things.
Comment 3 Andreas Kling 2011-02-28 09:51:09 PST
Comment on attachment 84069 [details]
Proposed patch

Clearing flags on attachment: 84069

Committed r79875: <http://trac.webkit.org/changeset/79875>
Comment 4 Andreas Kling 2011-02-28 09:51:16 PST
All reviewed patches have been landed.  Closing bug.