WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
55385
Use Frame::ownerElement() directly where appropriate.
https://bugs.webkit.org/show_bug.cgi?id=55385
Summary
Use Frame::ownerElement() directly where appropriate.
Andreas Kling
Reported
2011-02-28 09:00:57 PST
Don't take the roundabout way through frame->document->ownerElement which just checks that the document->frame is non-null.
Attachments
Proposed patch
(7.90 KB, patch)
2011-02-28 09:03 PST
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2011-02-28 09:03:06 PST
Created
attachment 84069
[details]
Proposed patch
Darin Adler
Comment 2
2011-02-28 09:45:45 PST
Comment on
attachment 84069
[details]
Proposed patch Ideally we’d remove redundant functions like these. It’s annoying to have the same function in both Document and Frame. We have many cases of this. Obviously we don’t want to go from Frame to Document and then have it just call back to Frame so this change is great given the current state of things.
Andreas Kling
Comment 3
2011-02-28 09:51:09 PST
Comment on
attachment 84069
[details]
Proposed patch Clearing flags on attachment: 84069 Committed
r79875
: <
http://trac.webkit.org/changeset/79875
>
Andreas Kling
Comment 4
2011-02-28 09:51:16 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug