Bug 55365 – REGRESSION (r79040): WebKit2: Large portions of pages with plugins paint black

• Status: RESOLVED
• Resolution: FIXED
• Component: Plug-ins

[Adam Roben (:aroben)]

To reproduce (in a build with the fix for bug 55364):

1. Launch MiniBrowser
2. Go to http://dictionary.reference.com/browse/miffy

Most of the page is black.

[Adam Roben (:aroben)]

<rdar://problem/9031089>

[Adam Roben (:aroben)]

Created attachment 84043 [details]
Pass the right dirty rect to Plugin::paint

[WebKit Review Bot]

Attachment 84043 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plat..." exit_code: 1

Tools/DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp:40:  The parameter name "saved" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Roben (:aroben)]

Comment on attachment 84043 [details]
Pass the right dirty rect to Plugin::paint

View in context: https://bugs.webkit.org/attachment.cgi?id=84043&action=review

>> Tools/DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp:40
>> +    virtual NPError NPP_New(NPMIMEType pluginType, uint16_t mode, int16_t argc, char *argn[], char *argv[], NPSavedData *saved);
> 
> The parameter name "saved" adds no information, so it should be removed.  [readability/parameter_name] [5]

Fixed. Also removed "pluginType", and fixed * placement.

[Adam Roben (:aroben)]

Committed r79863: <http://trac.webkit.org/changeset/79863>

[Simon Fraser (smfr)]

Thanks for fixing and all the testing work, Adam!