Bug 55360 – Web Inspector: add live edit test

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Podivilov]

Web Inspector: add live edit test.

[Pavel Podivilov]

Created attachment 84036 [details]
Patch.

[Pavel Feldman]

Comment on attachment 84036 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=84036&action=review

> LayoutTests/ChangeLog:14
> +        (f):

nuke this line.

> LayoutTests/http/tests/inspector/debugger-test.js:131
> +    InspectorTest.addResult("==Source frame contents start==");

I think there already is a highlighter test that is dumping text model content. Should we add editor-test.js with utility there?

> LayoutTests/inspector/debugger/live-edit.html:21
> +                sourceFrame._textViewer.editLine = InspectorTest.safeWrap(function(element, callback)

You should not override text viewer methods - what if the bug is in that line?

[Pavel Podivilov]

Created attachment 84047 [details]
Patch.

[Pavel Podivilov]

(In reply to comment #2)
> (From update of attachment 84036 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84036&action=review
> 
> > LayoutTests/ChangeLog:14
> > +        (f):
> 
> nuke this line.
Done.
> 
> > LayoutTests/http/tests/inspector/debugger-test.js:131
> > +    InspectorTest.addResult("==Source frame contents start==");
> 
> I think there already is a highlighter test that is dumping text model content. Should we add editor-test.js with utility there?

This method doesn't dump text model, it just dumps the contents. I think we shouldn't reuse highlighter test method here.

> 
> > LayoutTests/inspector/debugger/live-edit.html:21
> > +                sourceFrame._textViewer.editLine = InspectorTest.safeWrap(function(element, callback)
> 
> You should not override text viewer methods - what if the bug is in that line?
Done.

[Pavel Podivilov]

Committed r79880: <http://trac.webkit.org/changeset/79880>