Bug 55339 - applyInlineStyleToPushDown may apply style with CSS when pushing down styles even if styleWithCSS is false
Summary: applyInlineStyleToPushDown may apply style with CSS when pushing down styles ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on: 55338 55349 55452
Blocks:
  Show dependency treegraph
 
Reported: 2011-02-27 17:54 PST by Ryosuke Niwa
Modified: 2017-07-18 08:30 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-02-27 17:54:52 PST
Currently, ApplyStyleCommand::applyInlineStyleToPushDown sets style attribute to push down styles if the node has block flow style or has children.  The following fix me corresponds to this bug:

// FIXME: applyInlineStyleToRange should be used here instead.
if ((node->renderer()->isBlockFlow() || node->childNodeCount()) && node->isHTMLElement()) {
    setNodeAttribute(toHTMLElement(node), styleAttr, newInlineStyle->style()->cssText());
    return;
}
Comment 1 Brad Vogel 2012-09-27 16:00:46 PDT
My company's product - Inkling Habitat (inkling.com/habitat) - is blocked on this and would love to have it fixed!