Bug 55339 – applyInlineStyleToPushDown may apply style with CSS when pushing down styles even if styleWithCSS is false

• Status: NEW
• Component: HTML Editing

[Ryosuke Niwa]

Currently, ApplyStyleCommand::applyInlineStyleToPushDown sets style attribute to push down styles if the node has block flow style or has children.  The following fix me corresponds to this bug:

// FIXME: applyInlineStyleToRange should be used here instead.
if ((node->renderer()->isBlockFlow() || node->childNodeCount()) && node->isHTMLElement()) {
    setNodeAttribute(toHTMLElement(node), styleAttr, newInlineStyle->style()->cssText());
    return;
}

[Brad Vogel]

My company's product - Inkling Habitat (inkling.com/habitat) - is blocked on this and would love to have it fixed!

[Ahmad Saleem]

This FIXME is still present: https://github.com/WebKit/WebKit/blob/b48ba57fb5ed3acdd4f752c85fdf4f0f9fcd8e8d/Source/WebCore/editing/ApplyStyleCommand.cpp#L1022

Although all dependent bugs have been fixed.