Bug 55337 - Force dictionary popup to use overlay type
Summary: Force dictionary popup to use overlay type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-27 17:24 PST by Sam Weinig
Modified: 2011-02-27 20:35 PST (History)
0 users

See Also:

Attachments
Patch (1.98 KB, patch)
2011-02-27 17:26 PST, Sam Weinig 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-02-27 17:24:18 PST 
Force dictionary popup to use overlay type
Comment 1 Sam Weinig 2011-02-27 17:26:28 PST 
Created attachment 84006 [details]
Patch
Comment 2 mitz 2011-02-27 18:34:40 PST 
Comment on attachment 84006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84006&action=review

> Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm:430
> +    [m_wkView showDefinitionForAttributedString:attributedString.get()
> +                                          range:NSMakeRange(0, [attributedString.get() length])
> +                                        options:options
> +                         baselineOriginProvider:^(NSRange adjustedRange) { return (NSPoint)textBaselineOrigin; }];

Aligning arguments this way is not WebKit style. Please fix.
Comment 3 Sam Weinig 2011-02-27 20:35:37 PST 
Landed in r79839.