Bug 55322 - [Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJavaScriptWindowObject()
Summary: [Qt] Reference the documentation of the WebKit bridge from QWebFrame::addToJa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-02-27 10:09 PST by Benjamin Poulain
Modified: 2011-02-27 11:39 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.70 KB, patch)
2011-02-27 10:14 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-02-27 10:09:38 PST
The QtWebKit bridge documentation is important to do anything non-trivial with QWebFrame::addToJavaScriptWindowObject(), the page should be referenced from there so people would find it more easily.
Comment 1 Benjamin Poulain 2011-02-27 10:14:43 PST
Created attachment 83977 [details]
Patch
Comment 2 Andreas Kling 2011-02-27 10:15:45 PST
Comment on attachment 83977 [details]
Patch

Did you performance test this?
Comment 3 WebKit Commit Bot 2011-02-27 11:37:29 PST
The commit-queue encountered the following flaky tests while processing attachment 83977 [details]:

animations/play-state-suspend.html bug 50959 (author: cmarrin@apple.com)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2011-02-27 11:39:06 PST
Comment on attachment 83977 [details]
Patch

Clearing flags on attachment: 83977

Committed r79826: <http://trac.webkit.org/changeset/79826>
Comment 5 WebKit Commit Bot 2011-02-27 11:39:11 PST
All reviewed patches have been landed.  Closing bug.