WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 55301
55321
REGRESSION (
r79784
): Lots of tests failing assertions in Length::setValue on Windows
https://bugs.webkit.org/show_bug.cgi?id=55321
Summary
REGRESSION (r79784): Lots of tests failing assertions in Length::setValue on ...
Adam Roben (:aroben)
Reported
2011-02-27 09:54:35 PST
Lots of tests on Windows are failing assertions in Length::setValue. See the URL for some examples. The failing code is: FAULTING_SOURCE_CODE: 87: bool quirk() const { return m_quirk; } 88: 89: void setValue(LengthType t, int value) 90: {
> 91: ASSERT(t != Percent);
92: *this = Length(value, t); 93: } 94: 95: void setValue(int value) 96: { Here's an example backtrace: 00 0012e250 0150ba65 WebKit!WebCore::Length::setValue(WebCore::LengthType t = Percent (0n2), int value = 0n12800)+0x43 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\platform\length.h @ 91] 01 0012e394 0150af51 WebKit!WebCore::AutoTableLayout::calcEffectiveLogicalWidth(void)+0x505 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\autotablelayout.cpp @ 378] 02 0012e43c 015a7f4c WebKit!WebCore::AutoTableLayout::computePreferredLogicalWidths(int * minWidth = 0x0b606fe8, int * maxWidth = 0x0b606fec)+0x31 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\autotablelayout.cpp @ 226] 03 0012e45c 01545ee0 WebKit!WebCore::RenderTable::computePreferredLogicalWidths(void)+0xac [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\rendertable.cpp @ 574] 04 0012e46c 015a6276 WebKit!WebCore::RenderBox::minPreferredLogicalWidth(void)+0x30 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderbox.cpp @ 659] 05 0012e50c 015a67ed WebKit!WebCore::RenderTable::computeLogicalWidth(void)+0x146 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\rendertable.cpp @ 219] 06 0012e628 01529b70 WebKit!WebCore::RenderTable::layout(void)+0x12d [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\rendertable.cpp @ 278] 07 0012e6d0 01529844 WebKit!WebCore::RenderBlock::layoutBlockChild(class WebCore::RenderBox * child = 0x0b606f9c, class WebCore::RenderBlock::MarginInfo * marginInfo = 0x0012e738, int * previousFloatLogicalBottom = 0x0012e728, int * maxFloatLogicalBottom = 0x0012e870)+0x280 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1958] 08 0012e794 01526fe5 WebKit!WebCore::RenderBlock::layoutBlockChildren(bool relayoutChildren = true, int * maxFloatLogicalBottom = 0x0012e870)+0x364 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1897] 09 0012e8f8 01526b2e WebKit!WebCore::RenderBlock::layoutBlock(bool relayoutChildren = true, int pageLogicalHeight = 0n0)+0x465 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1227] 0a 0012e910 01529b70 WebKit!WebCore::RenderBlock::layout(void)+0x3e [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1120] 0b 0012e9b8 01529844 WebKit!WebCore::RenderBlock::layoutBlockChild(class WebCore::RenderBox * child = 0x0a33f474, class WebCore::RenderBlock::MarginInfo * marginInfo = 0x0012ea20, int * previousFloatLogicalBottom = 0x0012ea10, int * maxFloatLogicalBottom = 0x0012eb58)+0x280 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1958] 0c 0012ea7c 01526fe5 WebKit!WebCore::RenderBlock::layoutBlockChildren(bool relayoutChildren = true, int * maxFloatLogicalBottom = 0x0012eb58)+0x364 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1897] 0d 0012ebe0 01526b2e WebKit!WebCore::RenderBlock::layoutBlock(bool relayoutChildren = true, int pageLogicalHeight = 0n0)+0x465 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1227] 0e 0012ebf8 01529b70 WebKit!WebCore::RenderBlock::layout(void)+0x3e [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1120] 0f 0012eca0 01529844 WebKit!WebCore::RenderBlock::layoutBlockChild(class WebCore::RenderBox * child = 0x09f3a2b4, class WebCore::RenderBlock::MarginInfo * marginInfo = 0x0012ed08, int * previousFloatLogicalBottom = 0x0012ecf8, int * maxFloatLogicalBottom = 0x0012ee40)+0x280 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1958] 10 0012ed64 01526fe5 WebKit!WebCore::RenderBlock::layoutBlockChildren(bool relayoutChildren = true, int * maxFloatLogicalBottom = 0x0012ee40)+0x364 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1897] 11 0012eec8 01526b2e WebKit!WebCore::RenderBlock::layoutBlock(bool relayoutChildren = true, int pageLogicalHeight = 0n0)+0x465 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1227] 12 0012eee0 015cd0b5 WebKit!WebCore::RenderBlock::layout(void)+0x3e [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderblock.cpp @ 1120] 13 0012ef78 014e14fa WebKit!WebCore::RenderView::layout(void)+0x215 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\rendering\renderview.cpp @ 132] 14 0012f054 013928b3 WebKit!WebCore::FrameView::layout(bool allowSubtree = true)+0x93a [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\page\frameview.cpp @ 906] 15 0012f0a0 013478a4 WebKit!WebCore::Document::implicitClose(void)+0x353 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\dom\document.cpp @ 2123] 16 0012f0ac 01347620 WebKit!WebCore::FrameLoader::checkCallImplicitClose(void)+0x84 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\loader\frameloader.cpp @ 896] 17 0012f0c4 01347388 WebKit!WebCore::FrameLoader::checkCompleted(void)+0xf0 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\loader\frameloader.cpp @ 845] 18 0012f0e4 0139a70a WebKit!WebCore::FrameLoader::finishedParsing(void)+0x98 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\loader\frameloader.cpp @ 779] 19 0012f0fc 01edf1ec WebKit!WebCore::Document::finishedParsing(void)+0x18a [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\dom\document.cpp @ 4230] 1a 0012f10c 01c6f4c2 WebKit!WebCore::HTMLTreeBuilder::finished(void)+0x8c [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\html\parser\htmltreebuilder.cpp @ 2804] 1b 0012f11c 01c6f5d4 WebKit!WebCore::HTMLDocumentParser::end(void)+0xc2 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\html\parser\htmldocumentparser.cpp @ 355] 1c 0012f12c 01c6e7eb WebKit!WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd(void)+0xf4 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\html\parser\htmldocumentparser.cpp @ 364] 1d 0012f148 01c6f629 WebKit!WebCore::HTMLDocumentParser::prepareToStopParsing(void)+0xdb [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\html\parser\htmldocumentparser.cpp @ 152] 1e 0012f158 01c6f6e3 WebKit!WebCore::HTMLDocumentParser::attemptToEnd(void)+0x39 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\html\parser\htmldocumentparser.cpp @ 375] 1f 0012f164 01392e1b WebKit!WebCore::HTMLDocumentParser::finish(void)+0x33 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\html\parser\htmldocumentparser.cpp @ 404] 20 0012f178 01bbdded WebKit!WebCore::Document::finishParsing(void)+0x4b [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\dom\document.cpp @ 2232] 21 0012f190 01bbdd57 WebKit!WebCore::DocumentWriter::endIfNotLoadingMainResource(void)+0x7d [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\loader\documentwriter.cpp @ 223] 22 0012f19c 014c6b74 WebKit!WebCore::DocumentWriter::end(void)+0x27 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\loader\documentwriter.cpp @ 208] 23 0012f1ac 0134ceb2 WebKit!WebCore::DocumentLoader::finishedLoading(void)+0x54 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\loader\documentloader.cpp @ 286] 24 0012f1d4 01d082e6 WebKit!WebCore::FrameLoader::finishedLoading(void)+0x52 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\loader\frameloader.cpp @ 2193] 25 0012f204 019dc957 WebKit!WebCore::MainResourceLoader::didFinishLoading(double finishTime = 0)+0xe6 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\loader\mainresourceloader.cpp @ 465] 26 0012f21c 019788a1 WebKit!WebCore::ResourceLoader::didFinishLoading(class WebCore::ResourceHandle * __formal = 0x0b5e9768, double finishTime = 0)+0x27 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\loader\resourceloader.cpp @ 436] 27 0012f240 007dbfd4 WebKit!WebCore::didFinishLoading(struct _CFURLConnection * conn = 0x0b4ff310, void * clientInfo = 0x0b5e9768)+0xa1 [c:\cygwin\home\buildbot\slave\win-debug\build\source\webcore\platform\network\cf\resourcehandlecfnet.cpp @ 241] 28 0012f278 007dc337 CFNetwork!URLConnectionClient::_clientDidFinishLoading+0xb1 29 0012f37c 007dcf0b CFNetwork!URLConnectionClient::ClientConnectionEventQueue::processAllEventsAndConsumePayload+0xa6 2a 0012f38c 007dc6cd CFNetwork!XConnectionEventQueue<enum XLoaderEvent,XLoaderEventParams>::processAllEvents+0x14 2b 0012f3a0 007da495 CFNetwork!URLConnectionClient::processEvents+0x44 2c 0012f3ac 7e418734 CFNetwork!MirroredSet::contains+0x5b 2d 0012f3d8 7e418816 USER32!InternalCallWinProc+0x28 2e 0012f440 7e4189cd USER32!UserCallWinProcCheckWow+0x150 2f 0012f4a0 7e418a10 USER32!DispatchMessageWorker+0x306 30 0012f4b0 004586a5 USER32!DispatchMessageW+0xf 31 0012f624 0045748f DumpRenderTree!runTest(class std::basic_string<char,std::char_traits<char>,std::allocator<char> > * testPathOrURL = 0x0012f69c)+0x775 [c:\cygwin\home\buildbot\slave\win-debug\build\tools\dumprendertree\win\dumprendertree.cpp @ 1002] 32 0012ff7c 0046656f DumpRenderTree!main(int argc = 0n2, char ** argv = 0x051e9f70)+0x8df [c:\cygwin\home\buildbot\slave\win-debug\build\tools\dumprendertree\win\dumprendertree.cpp @ 1384] 33 0012ffc0 7c817077 DumpRenderTree!__tmainCRTStartup(void)+0x10f [f:\dd\vctools\crt_bld\self_x86\crt\src\crtexe.c @ 597] 34 0012fff0 00000000 kernel32!BaseProcessStart+0x23
Attachments
changed code to work around asserts + updated to real boolean values
(2.60 KB, patch)
2011-02-27 12:09 PST
,
Rik Cabanier
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1
2011-02-27 10:01:08 PST
*** This bug has been marked as a duplicate of
bug 55301
***
Rik Cabanier
Comment 2
2011-02-27 12:09:44 PST
Created
attachment 83984
[details]
changed code to work around asserts + updated to real boolean values
Eric Seidel (no email)
Comment 3
2011-03-08 09:47:09 PST
Comment on
attachment 83984
[details]
changed code to work around asserts + updated to real boolean values Cleared review? from
attachment 83984
[details]
so that this bug does not appear in
http://webkit.org/pending-review
. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug