Bug 55314 – [GTK] Build failed with ‘GDK_KEY_KP_Space’ was not declared in this scope

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

Steps to reproduce:

svn update
./autogen.sh --enable-web-sockets --enable-geolocation --enable-3D-transforms --enable-filters --enable-webkit2
make

After many hours of compilation:....
-----------------------------------------
.......
  CXX    Source/WebCore/bindings/js/libwebkit2gtk_1_0_la-JSDOMImplementationCustom.lo
  CXX    Source/WebCore/storage/libwebkit2gtk_1_0_la-IDBBackingStore.lo
  CXX    Source/WebCore/platform/graphics/gstreamer/libwebkit2gtk_1_0_la-GRefPtrGStreamer.lo
  CXX    Source/WebKit/gtk/webkit/libWebKit2_la-webkiterror.lo
  CXX    Source/WebKit2/Shared/gtk/libWebKit2_la-NativeWebKeyboardEventGtk.lo
  CXX    Source/WebKit2/Shared/gtk/libWebKit2_la-WebEventFactory.lo
Source/WebKit2/Shared/gtk/WebEventFactory.cpp: In function ‘bool WebKit::isGdkKeyCodeFromKeyPad(unsigned int)’:
Source/WebKit2/Shared/gtk/WebEventFactory.cpp:44: error: ‘GDK_KEY_KP_Space’ was not declared in this scope
Source/WebKit2/Shared/gtk/WebEventFactory.cpp:44: error: ‘GDK_KEY_KP_9’ was not declared in this scope
make[1]: *** [Source/WebKit2/Shared/gtk/libWebKit2_la-WebEventFactory.lo] Error 1

-------------------------------

svn info
Path: .
URL: http://svn.webkit.org/repository/webkit/trunk
Repository Root: http://svn.webkit.org/repository/webkit
Repository UUID: 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Revision: 79798
Node Kind: directory
Schedule: normal
Last Changed Author: [e-mail]
Last Changed Rev: 79798
Last Changed Date: 2011-02-26 10:26:08 -0800 (Sat, 26 Feb 2011)

------------------------------
Environment: Fedora13

Can you suggest me with what configure parameters of autogen.sh
webkit for GTK can be built from code in trunk of subversion?

[Martin Robinson]

Thanks for reporting this issue. Two thing that may interest you though:

1. 3D transformations are not implemented for GTK+ currently.
2. WebKit2 is far from usable with the GTK+ port currently.

./autogen.sh --enable-web-sockets --enable-mathml --enable-geolocation  --enable-filters --enable-directory-upload --enable-file-system --enable-webkit2


also ends with ....
---------------------------

  CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSFileWriter.lo
  CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSFileWriterCallback.lo
  CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSFileWriterSync.lo
  CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSFlags.lo
  CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSMetadata.lo
  CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSMetadataCallback.lo
  CXX    Source/WebKit2/Shared/gtk/libWebKit2_la-WebEventFactory.lo
Source/WebKit2/Shared/gtk/WebEventFactory.cpp: In function ‘bool WebKit::isGdkKeyCodeFromKeyPad(unsigned int)’:
Source/WebKit2/Shared/gtk/WebEventFactory.cpp:44: error: ‘GDK_KEY_KP_Space’ was not declared in this scope
Source/WebKit2/Shared/gtk/WebEventFactory.cpp:44: error: ‘GDK_KEY_KP_9’ was not declared in this scope
make[1]: *** [Source/WebKit2/Shared/gtk/libWebKit2_la-WebEventFactory.lo] Error 1

[Martin Robinson]

>   CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSFileWriter.lo
>   CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSFileWriterCallback.lo
>   CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSFileWriterSync.lo
>   CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSFlags.lo
>   CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSMetadata.lo
>   CXX    DerivedSources/WebCore/libwebkit2gtk_1_0_la-JSMetadataCallback.lo
>   CXX    Source/WebKit2/Shared/gtk/libWebKit2_la-WebEventFactory.lo
> Source/WebKit2/Shared/gtk/WebEventFactory.cpp: In function ‘bool WebKit::isGdkKeyCodeFromKeyPad(unsigned int)’:
> Source/WebKit2/Shared/gtk/WebEventFactory.cpp:44: error: ‘GDK_KEY_KP_Space’ was not declared in this scope
> Source/WebKit2/Shared/gtk/WebEventFactory.cpp:44: error: ‘GDK_KEY_KP_9’ was not declared in this scope
> make[1]: *** [Source/WebKit2/Shared/gtk/libWebKit2_la-WebEventFactory.lo] Error 1


What version of GDK/GTK+ do you have? GDK_KEY_KP_Space and GDK_KEY_KP_9 should be defined in gdkkeysyms.h.

I am on Fedora 13, and among rpm packages I see gtk2-2.20.1-1.fc13.i686, so probably my GTK version is 2.10.1


I do have file /usr/include/gtk-2.0/gdk/gdkkeysyms.h
and I can not find within it strings GDK_KEY_KP_9 or GDK_KEY_KP_Space

But when i was running ./autogen.sh, it was not telling me that my GTK version is too old, autogen.sh/configure do not check that

Marina

[Martin Robinson]

Committed r82318: <http://trac.webkit.org/changeset/82318>

[Martin Robinson]

(In reply to comment #6)
> Committed r82318: <http://trac.webkit.org/changeset/82318>

Thanks for reporting this issue! I believe it has been fixed in the repository. Feel free to reopen the issue if you still have problems.

[WebKit Review Bot]

http://trac.webkit.org/changeset/82318 might have broken Windows 7 Release (Tests)