Some parameters should be marked as optional with default values: Console::evaluate(in String expression, in String objectGroup, in [optional, default=0] number callFrameId, in [optional, default=true] boolean includeCommandLineAPI, out [typeRef=objectRef] Object result);
Created attachment 83930 [details] [patch] initial version
Are default/optional parameters really necessary?
(In reply to comment #2) > Are default/optional parameters really necessary? Yes. Things like column number while setting breakpoint, objectGroup while evaluating expression are optional. We should reflect it in the protocol. Protocol messages are simply maps. I don't even think all optional parameters should have default values. Like "not providing objectGroup for evaluation" means that user does not want element to be released with any named group, there is no default objectGroup he wants it in.
Comment on attachment 83930 [details] [patch] initial version View in context: https://bugs.webkit.org/attachment.cgi?id=83930&action=review Clearing r? until we come to agreement on what we want to see in the protocol wrt default parameters. > LayoutTests/inspector/protocol/Runtime-evaluate.html:8 > + console.error = function() Pavel is also overriding console.error in inspector-test.js in one of his changes so that now it prints out to the inspector test results. Please coordinate with him.