Bug 55288 - [Qt] Fix the focus in MiniBrowser.
Summary: [Qt] Fix the focus in MiniBrowser.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-02-25 19:45 PST by Yael
Modified: 2011-02-26 07:53 PST (History)
2 users (show)

See Also:

Attachments
Patch. (2.51 KB, patch)
2011-02-25 19:50 PST, Yael 		kling: review+
kling: commit-queue-
Details | Formatted Diff | Diff
Patch. (2.51 KB, patch)
2011-02-26 07:31 PST, Yael 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2011-02-25 19:45:40 PST 
Currently, loading pages such as www.google.com show a caret blinking both in the address bar and in the search box.
This is really annoying :)
Comment 1 Yael 2011-02-25 19:50:58 PST 
Created attachment 83919 [details]
Patch.

Basic focus functionality.
Note that isVisible() is called before the view is created thus the extra check.
Comment 2 Andreas Kling 2011-02-26 05:32:15 PST 
Comment on attachment 83919 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=83919&action=review

> Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:168
> +    return view->isActive();

No null check for 'view'?

> Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:173
> +    return view->hasFocus();

No null check for 'view'?

> Source/WebKit2/UIProcess/API/qt/qwkpage.cpp:178
> +    return view ? view->isVisible() : false;

return view && view->isVisible();
Comment 3 Andreas Kling 2011-02-26 05:33:05 PST 
(In reply to comment #1)
> Note that isVisible() is called before the view is created thus the extra check.

D'oh. Another case of I-went-straight-to-the-patch-review-interface.
Comment 4 Yael 2011-02-26 07:31:26 PST 
Created attachment 83941 [details]
Patch.
Comment 5 WebKit Commit Bot 2011-02-26 07:53:18 PST 
Comment on attachment 83941 [details]
Patch.

Clearing flags on attachment: 83941

Committed r79791: <http://trac.webkit.org/changeset/79791>
Comment 6 WebKit Commit Bot 2011-02-26 07:53:22 PST 
All reviewed patches have been landed.  Closing bug.