RESOLVED WONTFIX 55278
V8 IDL code generator shouldn't emit an #include line for DOMString. 
https://bugs.webkit.org/show_bug.cgi?id=55278
Summary V8 IDL code generator shouldn't emit an #include line for DOMString.
Daniel Cheng
Reported 2011-02-25 17:36:47 PST
V8 IDL code generator shouldn't emit an #include line for DOMString.
Attachments
Patch (1.54 KB, patch)
2011-02-25 17:39 PST, Daniel Cheng 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Cheng
Comment 1 2011-02-25 17:39:12 PST
Created attachment 83905 [details] Patch
Daniel Cheng
Comment 2 2011-02-25 17:40:57 PST
I notice there's a test subdir, but I'm not sure how to run the tests contains within. Any tips?
Darin Adler
Comment 3 2011-02-25 17:40:58 PST
Comment on attachment 83905 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83905&action=review > Source/WebCore/ChangeLog:8 > + No new tests, since I haven't figured out how to run them (OOPS!). You are supposed to runt them by typing "run-bindings-tests" at the command line. I tried just now and they seem to be broken.
Daniel Cheng
Comment 4 2011-02-28 18:33:21 PST
Fixing the code generator as part of https://bugs.webkit.org/show_bug.cgi?id=55115. Landing this patch by itself wouldn't do too much, and the IDL generator tests are somewhat stale at the moment.
Eric Seidel (no email)
Comment 5 2011-03-08 09:46:40 PST
Comment on attachment 83905 [details] Patch Cleared review? from attachment 83905 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.