Bug 55269 - [chromium] Fall back to texSubImage2D when mapTexSubImage2D fails in VideoLayerChromium
Summary: [chromium] Fall back to texSubImage2D when mapTexSubImage2D fails in VideoLay...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 53608 54694
  Show dependency tree / graph
 
Reported: 2011-02-25 15:10 PST by Victoria Kirst
Modified: 2011-02-28 15:36 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.05 KB, patch)
2011-02-25 15:13 PST, Victoria Kirst 		no flags Details | Formatted Diff | Diff
Patch (2.03 KB, patch)
2011-02-28 13:33 PST, Victoria Kirst 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Victoria Kirst 2011-02-25 15:10:33 PST 
[chromium] Fall back to texSubImage2D when mapTexSubImage2D fails in VideoLayerChromium
Comment 1 Victoria Kirst 2011-02-25 15:13:03 PST 
Created attachment 83887 [details]
Patch
Comment 2 Victoria Kirst 2011-02-25 15:18:56 PST 
This fix will enable <videos> to be painted in DRT with GPU-acceleration turned on.
Comment 3 Kenneth Russell 2011-02-28 13:07:42 PST 
Comment on attachment 83887 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83887&action=review

> Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp:224
> +        GLC(context, context->texSubImage2D(GraphicsContext3D::TEXTURE_2D, 0, 0, 0, dimensions.width(), dimensions.height(), GraphicsContext3D::LUMINANCE, GraphicsContext3D::UNSIGNED_BYTE, data));

Should this use the incoming argument "format" instead of GraphicsContext3D::LUMINANCE directly?
Comment 4 Victoria Kirst 2011-02-28 13:33:09 PST 
Created attachment 84108 [details]
Patch
Comment 5 Victoria Kirst 2011-02-28 13:34:09 PST 
(In reply to comment #3)
> Should this use the incoming argument "format" instead of GraphicsContext3D::LUMINANCE directly?

Yes! Thanks for the catch. Fixed in my uploaded patch.
Comment 6 Kenneth Russell 2011-02-28 13:41:20 PST 
Comment on attachment 84108 [details]
Patch

Looks good.
Comment 7 WebKit Commit Bot 2011-02-28 15:36:09 PST 
Comment on attachment 84108 [details]
Patch

Clearing flags on attachment: 84108

Committed r79935: <http://trac.webkit.org/changeset/79935>
Comment 8 WebKit Commit Bot 2011-02-28 15:36:14 PST 
All reviewed patches have been landed.  Closing bug.