Bug 55258 – [EFL] API for application cache database directory path moved from ewk_view to ewk_setting because of wrong logic

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebKit EFL

[Lukasz Slachciak]

In ewk_view.cpp there is an API for setting and getting application cache directory path.
It is wrong approach because in one WebKit instance only one cache directory path can be set with:
WebCore::cacheStorage().setCacheDirectory().
Allowing to set this for each view was misleading because it was changing path in other views also

Attached patch fixes this problem proposing new API in ewk_settings.h:

EAPI void             ewk_settings_application_cache_path_set(const char *path);
EAPI const char      *ewk_settings_application_cache_path_get();

[Lukasz Slachciak]

Created attachment 83871 [details]
API for application cache database directory

[Gyuyoung Kim]

Comment on attachment 83871 [details]
API for application cache database directory

View in context: https://bugs.webkit.org/attachment.cgi?id=83871&action=review

> Source/WebKit/efl/ChangeLog:5
> +        API for application cache database directory path moved from ewk_view to ewk_settings

Please sync with bug title.

> Source/WebKit/efl/ChangeLog:6
> +

Please add bug url

> Source/WebKit/efl/ewk/ewk_settings.cpp:147
> +        eina_stringshare_replace(&_ewk_application_cache_database_path, path);

We should prepare that the "OFFLINE_WEB_APPLICATIONS" is disabled,
For example,

#else
    return;
#endif

> Source/WebKit/efl/ewk/ewk_settings.cpp:164
> +    return _ewk_application_cache_database_path;

Same with above.

[Lukasz Slachciak]

Created attachment 83931 [details]
API for application cache database directory

[Lukasz Slachciak]

Thank you Gyuyoung for comments. I followed them.

[Ryuan Choi]

I am sorry about late answer.
It looks duplicated with https://bugs.webkit.org/show_bug.cgi?id=52139

[Lukasz Slachciak]

*** This bug has been marked as a duplicate of bug 52139 ***

[Lukasz Slachciak]

Thank you Ryuan for comment. I resolved this bug as duplicate, but please take care about adding  #if ENABLE(OFFLINE_WEB_APPLICATIONS) in your patch

[Eric Seidel (no email)]

Comment on attachment 83931 [details]
API for application cache database directory

Cleared review? from attachment 83931 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).