RESOLVED FIXED 55245
input element's placeholder text stays visible when suggestion text is applied 
https://bugs.webkit.org/show_bug.cgi?id=55245
Summary input element's placeholder text stays visible when suggestion text is applied
David Holloway
Reported Friday, February 25, 2011 7:22:37 PM UTC
Steps: 1. Launch Chrome with Form Autofill enabled 2. Surf to http://www.slugworth.com/autofill/form_placeholder.html 3. Notice the placeholder text visible in the form 4. Double click on an input element to trigger Autofill suggestions to appear Result: The suggestion text is composited on top of the placeholder text. Expect: The suggestion text should replace the placeholder text, not composite on top of it. Ie. placeholder text should be invisible.
Attachments
Patch (3.99 KB, patch)
2011-02-25 11:36 PST, David Holloway 		no flags
DetailsFormatted DiffDiff
Patch (5.03 KB, patch)
2011-02-25 11:53 PST, David Holloway 		no flags
DetailsFormatted DiffDiff
Updated ChangeLog with explanation for no new tests. Thanks! (5.10 KB, patch)
2011-03-02 10:15 PST, David Holloway 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
David Holloway
Comment 1 Friday, February 25, 2011 7:36:04 PM UTC
Created attachment 83856 [details] Patch
David Holloway
Comment 2 Friday, February 25, 2011 7:53:08 PM UTC
Created attachment 83860 [details] Patch
David Holloway
Comment 3 Friday, February 25, 2011 7:56:34 PM UTC
This time with ChangeLog. Darin, please let me know layout test is expected with this. Thanks.
David Holloway
Comment 4 Tuesday, March 1, 2011 9:45:41 PM UTC
Ping.
Dimitri Glazkov (Google)
Comment 5 Wednesday, March 2, 2011 5:28:39 PM UTC
Comment on attachment 83860 [details] Patch I think this is testable using a layout test, right?
David Holloway
Comment 6 Wednesday, March 2, 2011 5:30:58 PM UTC
Actually, I looked into it and it does not seem testable in a Layout test, no. This is because, by design, the suggestion text is not accessible through the DOM.
Dimitri Glazkov (Google)
Comment 7 Wednesday, March 2, 2011 5:49:01 PM UTC
(In reply to comment #6) > Actually, I looked into it and it does not seem testable in a Layout test, no. This is because, by design, the suggestion text is not accessible through the DOM. I see. Then this looks ok, except for the explanation in the ChangeLog on why there's no layout test :)
David Holloway
Comment 8 Wednesday, March 2, 2011 6:15:47 PM UTC
Created attachment 84433 [details] Updated ChangeLog with explanation for no new tests. Thanks!
Dimitri Glazkov (Google)
Comment 9 Wednesday, March 2, 2011 6:17:10 PM UTC
Comment on attachment 84433 [details] Updated ChangeLog with explanation for no new tests. Thanks! ok.
WebKit Commit Bot
Comment 10 Thursday, March 3, 2011 12:15:24 PM UTC
Comment on attachment 84433 [details] Updated ChangeLog with explanation for no new tests. Thanks! Clearing flags on attachment: 84433 Committed r80232: <http://trac.webkit.org/changeset/80232>
WebKit Commit Bot
Comment 11 Thursday, March 3, 2011 12:15:30 PM UTC
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.