Bug 55245 - input element's placeholder text stays visible when suggestion text is applied
Summary: input element's placeholder text stays visible when suggestion text is applied
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL: http://www.slugworth.com/autofill/for...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-25 11:22 PST by David Holloway
Modified: 2011-03-03 04:15 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.99 KB, patch)
2011-02-25 11:36 PST, David Holloway 		no flags Details | Formatted Diff | Diff
Patch (5.03 KB, patch)
2011-02-25 11:53 PST, David Holloway 		no flags Details | Formatted Diff | Diff
Updated ChangeLog with explanation for no new tests. Thanks! (5.10 KB, patch)
2011-03-02 10:15 PST, David Holloway 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Holloway 2011-02-25 11:22:37 PST 
Steps:
  1. Launch Chrome with Form Autofill enabled
  2. Surf to http://www.slugworth.com/autofill/form_placeholder.html
  3. Notice the placeholder text visible in the form
  4. Double click on an input element to trigger Autofill suggestions to appear
  
Result:
  The suggestion text is composited on top of the placeholder text.

Expect:
  The suggestion text should replace the placeholder text, not composite on top of it.  Ie. placeholder text should be invisible.
Comment 1 David Holloway 2011-02-25 11:36:04 PST 
Created attachment 83856 [details]
Patch
Comment 2 David Holloway 2011-02-25 11:53:08 PST 
Created attachment 83860 [details]
Patch
Comment 3 David Holloway 2011-02-25 11:56:34 PST 
This time with ChangeLog.  Darin, please let me know layout test is expected with this.  Thanks.
Comment 4 David Holloway 2011-03-01 13:45:41 PST 
Ping.
Comment 5 Dimitri Glazkov (Google) 2011-03-02 09:28:39 PST 
Comment on attachment 83860 [details]
Patch

I think this is testable using a layout test, right?
Comment 6 David Holloway 2011-03-02 09:30:58 PST 
Actually, I looked into it and it does not seem testable in a Layout test, no.  This is because, by design, the suggestion text is not accessible through the DOM.
Comment 7 Dimitri Glazkov (Google) 2011-03-02 09:49:01 PST 
(In reply to comment #6)
> Actually, I looked into it and it does not seem testable in a Layout test, no.  This is because, by design, the suggestion text is not accessible through the DOM.

I see. Then this looks ok, except for the explanation in the ChangeLog on why there's no layout test :)
Comment 8 David Holloway 2011-03-02 10:15:47 PST 
Created attachment 84433 [details]
Updated ChangeLog with explanation for no new tests.  Thanks!
Comment 9 Dimitri Glazkov (Google) 2011-03-02 10:17:10 PST 
Comment on attachment 84433 [details]
Updated ChangeLog with explanation for no new tests.  Thanks!

ok.
Comment 10 WebKit Commit Bot 2011-03-03 04:15:24 PST 
Comment on attachment 84433 [details]
Updated ChangeLog with explanation for no new tests.  Thanks!

Clearing flags on attachment: 84433

Committed r80232: <http://trac.webkit.org/changeset/80232>
Comment 11 WebKit Commit Bot 2011-03-03 04:15:30 PST 
All reviewed patches have been landed.  Closing bug.