Bug 55233 - XSL transformations do not handle errors
: XSL transformations do not handle errors
Status: UNCONFIRMED
: WebKit
Layout and Rendering
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
: 64305
:
  Show dependency treegraph
 
Reported: 2011-02-25 10:37 PST by
Modified: 2011-07-11 12:19 PST (History)


Attachments
Patch (No tests) (48.28 KB, patch)
2011-05-25 16:15 PST, Vsevolod Vlasov
abarth: review-
webkit-ews: commit‑queue-
Review Patch | Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-01 (1.32 MB, application/zip)
2011-05-25 23:02 PST, WebKit Review Bot
no flags Details


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-02-25 10:37:40 PST
When there was an error applying XSL transformation, the blank page is shown or sometimes the previous page content keeps showing.
Firefox reports such errors.
------- Comment #1 From 2011-05-25 16:15:29 PST -------
Created an attachment (id=94877) [details]
Patch (No tests)

First attempt
------- Comment #2 From 2011-05-25 16:24:54 PST -------
(From update of attachment 94877 [details])
Attachment 94877 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8730970
------- Comment #3 From 2011-05-25 17:43:31 PST -------
(From update of attachment 94877 [details])
Attachment 94877 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8731884
------- Comment #4 From 2011-05-25 23:02:16 PST -------
(From update of attachment 94877 [details])
Attachment 94877 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8739040

New failing tests:
svg/custom/use-invalid-html.xhtml
fast/parser/xml-colon-entity.html
svg/custom/bug45331.svg
fast/dom/set-innerHTML.xhtml
svg/custom/use-invalid-style.svg
svg/custom/path-bad-data.svg
svg/custom/junk-data.svg
fast/parser/badentity.xhtml
fast/parser/xhtml-alternate-entities.xml
svg/custom/use-invalid-pattern.svg
svg/custom/missing-xlink.svg
fast/encoding/invalid-xml.html
fast/xsl/xslt-extra-content-at-end.xml
fast/frames/onlyCommentInIFrame.html
fast/text/bad-encoding.html
fast/parser/xml-declaration-missing-ending-mark.html
fast/parser/external-entities.xml
svg/custom/use-crash-in-non-wellformed-document.svg
fast/css/stylesheet-candidate-nodes-crash.xhtml
------- Comment #5 From 2011-05-25 23:02:21 PST -------
Created an attachment (id=94920) [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
------- Comment #6 From 2011-05-26 09:59:05 PST -------
(From update of attachment 94877 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=94877&action=review

This looks pretty cool, but we'll need some tests!  (I didn't review deeply.)

> Source/WebCore/xml/XMLErrors.cpp:68
> +            m_errorMessages += "warning in " + sourceURL + " on line" + String::number(position.m_line.oneBasedInt()) + " at column " + String::number(position.m_column.oneBasedInt()) + ": " + m;

Is there an XSS risk here?  Should we sandbox error pages to be extra-sure?