Bug 55227 - old-run-webkit-tests falsely claims to be saving crash logs on Windows Vista/7
Summary: old-run-webkit-tests falsely claims to be saving crash logs on Windows Vista/7
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords: PlatformOnly
Depends on:
Blocks:
 
Reported: 2011-02-25 09:48 PST by Adam Roben (:aroben)
Modified: 2011-02-25 10:50 PST (History)
2 users (show)

See Also:

Attachments
Double-check that modifying the registry worked (1.89 KB, patch)
2011-02-25 09:53 PST, Adam Roben (:aroben) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-02-25 09:48:31 PST 
old-run-webkit-tests modifies the registry to configure a post-mortem debugger to save crash logs. This doesn't work on Windows Vista/7 because you need administrator privileges to modify the registry. But old-run-webkit-tests thinks it successfully modified the registry and thus claims to be saving crash logs.

Actually making crash log saving work is covered by bug 44135. But in the meantime we should make old-run-webkit-tests stop lying.
Comment 1 Adam Roben (:aroben) 2011-02-25 09:53:11 PST 
Created attachment 83827 [details]
Double-check that modifying the registry worked
Comment 2 Adam Roben (:aroben) 2011-02-25 10:50:31 PST 
Committed r79698: <http://trac.webkit.org/changeset/79698>