Bug 55224 - old-run-webkit-test's Windows registry code is ugly
Summary: old-run-webkit-test's Windows registry code is ugly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks: 55225
  Show dependency treegraph
 
Reported: 2011-02-25 09:24 PST by Adam Roben (:aroben)
Modified: 2011-02-25 10:49 PST (History)
1 user (show)

See Also:


Attachments
Patch (3.08 KB, patch)
2011-02-25 09:26 PST, Adam Roben (:aroben)
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-02-25 09:24:54 PST
old-run-webkit-test's Windows registry code is ugly
Comment 1 Adam Roben (:aroben) 2011-02-25 09:26:32 PST
Created attachment 83823 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2011-02-25 10:38:58 PST
Comment on attachment 83823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83823&action=review

r=me

> Tools/Scripts/old-run-webkit-tests:2607
> +    my ($valueName) = @_;

Maybe $key instead of $valueName?

> Tools/Scripts/old-run-webkit-tests:2614
> +    my ($valueName, $data) = @_;

Maybe ($key, $value) instead of ($valueName, $data)?
Comment 3 Adam Roben (:aroben) 2011-02-25 10:45:13 PST
Comment on attachment 83823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83823&action=review

>> Tools/Scripts/old-run-webkit-tests:2607
>> +    my ($valueName) = @_;
> 
> Maybe $key instead of $valueName?

Unfortunately, "key" has a different meaning in registry-speak. (The registry is a tree. Leaf nodes are called "values", and a value has a name, a type, and some data associated with it. Non-leaf nodes are called "keys", and just have a name.)

>> Tools/Scripts/old-run-webkit-tests:2614
>> +    my ($valueName, $data) = @_;
> 
> Maybe ($key, $value) instead of ($valueName, $data)?

I changed $data to $string, but left $valueName alone.
Comment 4 Adam Roben (:aroben) 2011-02-25 10:49:29 PST
Committed r79696: <http://trac.webkit.org/changeset/79696>