RESOLVED FIXED 55224
old-run-webkit-test's Windows registry code is ugly 
https://bugs.webkit.org/show_bug.cgi?id=55224
Summary old-run-webkit-test's Windows registry code is ugly
Adam Roben (:aroben)
Reported 2011-02-25 09:24:54 PST
old-run-webkit-test's Windows registry code is ugly
Attachments
Patch (3.08 KB, patch)
2011-02-25 09:26 PST, Adam Roben (:aroben) 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-02-25 09:26:32 PST
Created attachment 83823 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2011-02-25 10:38:58 PST
Comment on attachment 83823 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83823&action=review r=me > Tools/Scripts/old-run-webkit-tests:2607 > + my ($valueName) = @_; Maybe $key instead of $valueName? > Tools/Scripts/old-run-webkit-tests:2614 > + my ($valueName, $data) = @_; Maybe ($key, $value) instead of ($valueName, $data)?
Adam Roben (:aroben)
Comment 3 2011-02-25 10:45:13 PST
Comment on attachment 83823 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=83823&action=review >> Tools/Scripts/old-run-webkit-tests:2607 >> + my ($valueName) = @_; > > Maybe $key instead of $valueName? Unfortunately, "key" has a different meaning in registry-speak. (The registry is a tree. Leaf nodes are called "values", and a value has a name, a type, and some data associated with it. Non-leaf nodes are called "keys", and just have a name.) >> Tools/Scripts/old-run-webkit-tests:2614 >> + my ($valueName, $data) = @_; > > Maybe ($key, $value) instead of ($valueName, $data)? I changed $data to $string, but left $valueName alone.
Adam Roben (:aroben)
Comment 4 2011-02-25 10:49:29 PST
Committed r79696: <http://trac.webkit.org/changeset/79696>
Note You need to log in before you can comment on or make changes to this bug.