Bug 55211 – PumpSession should not call currentTime() in the constructor

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

PumpSession should not call currentTime() in the constructor

[Eric Seidel (no email)]

Created attachment 83791 [details]
Patch

[WebKit Review Bot]

Attachment 83791 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8043173

[Eric Seidel (no email)]

Created attachment 83792 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 83792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83792&action=review

> Source/WebCore/html/parser/HTMLParserScheduler.h:68
> +            // currentTime() can be expensive.  By delaying, we avoided calling

One space after periods please.

[Tony Gentilcore]

LGTM

[Eric Seidel (no email)]

I can't believe this got forgotten for a month due to a space after a period. :(

[Eric Seidel (no email)]

(That's not a knock against the style guide.  Just annoyed that I forgot the patch.)

Peacekeeper will be even faster once this lands. :)

[WebKit Commit Bot]

Comment on attachment 83792 [details]
Patch

Rejecting attachment 83792 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2

Last 500 characters of output:
ith fuzz 3.
patching file Source/WebCore/html/parser/HTMLDocumentParser.cpp
Hunk #1 succeeded at 40 (offset 1 line).
patching file Source/WebCore/html/parser/HTMLParserScheduler.h
Hunk #1 FAILED at 26.
Hunk #2 FAILED at 38.
Hunk #3 succeeded at 68 (offset 3 lines).
2 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/html/parser/HTMLParserScheduler.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Simon Fraser', u'--for..." exit_code: 1

Full output: http://queues.webkit.org/results/8285412

[Eric Seidel (no email)]

Created attachment 89581 [details]
Patch for landing

[Eric Seidel (no email)]

Created attachment 89584 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 89584 [details]:

media/video-playbackrate.html bug 58629 (author: [e-mail])
media/video-played-collapse.html bug 58630 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 89584 [details]
Patch for landing

Clearing flags on attachment: 89584

Committed r83940: <http://trac.webkit.org/changeset/83940>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.