Bug 55211 - PumpSession should not call currentTime() in the constructor
Summary: PumpSession should not call currentTime() in the constructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 48719
  Show dependency tree / graph
 
Reported: 2011-02-25 03:53 PST by Eric Seidel (no email)
Modified: 2011-04-14 20:49 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.26 KB, patch)
2011-02-25 04:04 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch (3.44 KB, patch)
2011-02-25 04:12 PST, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch for landing (3.53 KB, patch)
2011-04-14 07:59 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Patch for landing (3.54 KB, patch)
2011-04-14 08:06 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-02-25 03:53:19 PST 
PumpSession should not call currentTime() in the constructor
Comment 1 Eric Seidel (no email) 2011-02-25 04:04:31 PST 
Created attachment 83791 [details]
Patch
Comment 2 WebKit Review Bot 2011-02-25 04:08:08 PST 
Attachment 83791 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8043173
Comment 3 Eric Seidel (no email) 2011-02-25 04:12:26 PST 
Created attachment 83792 [details]
Patch
Comment 4 Simon Fraser (smfr) 2011-02-25 08:30:43 PST 
Comment on attachment 83792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83792&action=review

> Source/WebCore/html/parser/HTMLParserScheduler.h:68
> +            // currentTime() can be expensive.  By delaying, we avoided calling

One space after periods please.
Comment 5 Tony Gentilcore 2011-02-25 08:33:18 PST 
LGTM
Comment 6 Eric Seidel (no email) 2011-03-29 11:57:27 PDT 
I can't believe this got forgotten for a month due to a space after a period. :(
Comment 7 Eric Seidel (no email) 2011-03-29 11:58:16 PDT 
(That's not a knock against the style guide.  Just annoyed that I forgot the patch.)

Peacekeeper will be even faster once this lands. :)
Comment 8 WebKit Commit Bot 2011-03-29 12:02:01 PDT 
Comment on attachment 83792 [details]
Patch

Rejecting attachment 83792 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2

Last 500 characters of output:
ith fuzz 3.
patching file Source/WebCore/html/parser/HTMLDocumentParser.cpp
Hunk #1 succeeded at 40 (offset 1 line).
patching file Source/WebCore/html/parser/HTMLParserScheduler.h
Hunk #1 FAILED at 26.
Hunk #2 FAILED at 38.
Hunk #3 succeeded at 68 (offset 3 lines).
2 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/html/parser/HTMLParserScheduler.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Simon Fraser', u'--for..." exit_code: 1

Full output: http://queues.webkit.org/results/8285412
Comment 9 Eric Seidel (no email) 2011-04-14 07:59:38 PDT 
Created attachment 89581 [details]
Patch for landing
Comment 10 Eric Seidel (no email) 2011-04-14 08:06:41 PDT 
Created attachment 89584 [details]
Patch for landing
Comment 11 WebKit Commit Bot 2011-04-14 20:45:45 PDT 
The commit-queue encountered the following flaky tests while processing attachment 89584 [details]:

media/video-playbackrate.html bug 58629 (author: eric.carlson@apple.com)
media/video-played-collapse.html bug 58630 (authors: hclam@google.com and jamesr@chromium.org)
The commit-queue is continuing to process your patch.
Comment 12 WebKit Commit Bot 2011-04-14 20:49:06 PDT 
Comment on attachment 89584 [details]
Patch for landing

Clearing flags on attachment: 89584

Committed r83940: <http://trac.webkit.org/changeset/83940>
Comment 13 WebKit Commit Bot 2011-04-14 20:49:12 PDT 
All reviewed patches have been landed.  Closing bug.