Bug 55207 - Move HTMLEquivalent and its subclasses to EditingStyle
Summary: Move HTMLEquivalent and its subclasses to EditingStyle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 49956
  Show dependency tree / graph
 
Reported: 2011-02-25 00:06 PST by Ryosuke Niwa
Modified: 2011-02-25 21:26 PST (History)
7 users (show)

See Also:

Attachments
cleanup (30.73 KB, patch)
2011-02-25 00:20 PST, Ryosuke Niwa 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-02-25 00:06:03 PST 
Right now, ApplyStyleCommand is responsible for both determining which style, elements, attributes to be removed and to be added.  In the long run, we'd like to move this responsibility over to EditingStyle.

This is bug is about moving HTMLEquivalent and its subclasses along with the logic to determine which elements and attributes are moved from ApplyStyleCommand to EditingStyle.  While this introduces a slight overhad, it simplifies the code in ApplyStyleCommand significantly and helps to separate the responsibilities of ApplyStyleCommand and EditingStyle so it should be a win in the long term.
Comment 1 Ryosuke Niwa 2011-02-25 00:20:34 PST 
Created attachment 83779 [details]
cleanup
Comment 2 Ryosuke Niwa 2011-02-25 21:26:46 PST 
Committed r79758: <http://trac.webkit.org/changeset/79758>