WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
55205
HashSet<T>::end() creation is expensive and should be avoided
https://bugs.webkit.org/show_bug.cgi?id=55205
Summary
HashSet<T>::end() creation is expensive and should be avoided
Eric Seidel (no email)
Reported
Friday, February 25, 2011 7:20:45 AM UTC
HashSet<T>::end() creation is expensive and should be avoided
Attachments
Patch
(5.09 KB, patch)
2011-02-24 23:22 PST
,
Eric Seidel (no email)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
Friday, February 25, 2011 7:22:28 AM UTC
Created
attachment 83776
[details]
Patch
Maciej Stachowiak
Comment 2
Friday, February 25, 2011 7:28:58 AM UTC
Comment on
attachment 83776
[details]
Patch r=me
WebKit Commit Bot
Comment 3
Saturday, February 26, 2011 1:46:23 PM UTC
Comment on
attachment 83776
[details]
Patch Rejecting
attachment 83776
[details]
from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'bu..." exit_code: 2 Last 500 characters of output: .......................................................................................................... http/tests/ssl ... http/tests/storage . http/tests/uri .... http/tests/webarchive ..... http/tests/websocket/tests .......................... http/tests/websocket/tests/multiple-connections.html -> failed Exiting early after 1 failures. 22543 tests run. 703.11s total testing time 22542 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 14 test cases (<1%) had stderr output Full output:
http://queues.webkit.org/results/8034759
WebKit Commit Bot
Comment 4
Saturday, February 26, 2011 1:47:29 PM UTC
Comment on
attachment 83776
[details]
Patch Clearing flags on attachment: 83776 Committed
r79780
: <
http://trac.webkit.org/changeset/79780
>
WebKit Commit Bot
Comment 5
Saturday, February 26, 2011 1:47:35 PM UTC
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 6
Saturday, February 26, 2011 5:22:24 PM UTC
Maybe we could special case HashTable::end since the hash table knows its empty and could just return begin in that case.
WebKit Review Bot
Comment 7
Sunday, February 27, 2011 5:01:22 PM UTC
http://trac.webkit.org/changeset/79780
might have broken GTK Linux 64-bit Debug
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug