Bug 55200 – [chromium] Don't clear existing files if file chooser is canceled

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sailesh Agrawal]

Don't clear existing files if file chooser is canceled

[Sailesh Agrawal]

Created attachment 83757 [details]
Patch

[Kent Tamura]

(In reply to comment #0)
> Don't clear existing files if file chooser is canceled

Why? Without the current behavior, users can't clear the selected file.
Though the current behavior is not compatible with Safari, I think it's intentional.

[Sailesh Agrawal]

(In reply to comment #2)
> (In reply to comment #0)
> > Don't clear existing files if file chooser is canceled
> 
> Why? Without the current behavior, users can't clear the selected file.

This is a usability bug. Cancel should always abort the current operation. If we need a way to clear the selected file then we should add a separate way to do that.

> Though the current behavior is not compatible with Safari, I think it's intentional.
It's not about being compatible with Safari. I just tried Firefox and it does the same thing as Safari too.

[Darin Fisher (:fishd, Google)]

Comment on attachment 83757 [details]
Patch

Agreed.  This seems like the right fix to me.  Cancelling a dialog should leave existing state unchanged.

[WebKit Commit Bot]

Comment on attachment 83757 [details]
Patch

Clearing flags on attachment: 83757

Committed r82914: <http://trac.webkit.org/changeset/82914>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/82914 might have broken GTK Linux 32-bit Debug