Bug 55200 - [chromium] Don't clear existing files if file chooser is canceled
Summary: [chromium] Don't clear existing files if file chooser is canceled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-24 18:04 PST by Sailesh Agrawal
Modified: 2011-04-05 03:50 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.32 KB, patch)
2011-02-24 18:05 PST, Sailesh Agrawal 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sailesh Agrawal 2011-02-24 18:04:22 PST 
Don't clear existing files if file chooser is canceled
Comment 1 Sailesh Agrawal 2011-02-24 18:05:34 PST 
Created attachment 83757 [details]
Patch
Comment 2 Kent Tamura 2011-02-26 06:43:44 PST 
(In reply to comment #0)
> Don't clear existing files if file chooser is canceled

Why? Without the current behavior, users can't clear the selected file.
Though the current behavior is not compatible with Safari, I think it's intentional.
Comment 3 Sailesh Agrawal 2011-02-27 08:28:12 PST 
(In reply to comment #2)
> (In reply to comment #0)
> > Don't clear existing files if file chooser is canceled
> 
> Why? Without the current behavior, users can't clear the selected file.

This is a usability bug. Cancel should always abort the current operation. If we need a way to clear the selected file then we should add a separate way to do that.

> Though the current behavior is not compatible with Safari, I think it's intentional.
It's not about being compatible with Safari. I just tried Firefox and it does the same thing as Safari too.
Comment 4 Darin Fisher (:fishd, Google) 2011-04-04 21:20:11 PDT 
Comment on attachment 83757 [details]
Patch

Agreed.  This seems like the right fix to me.  Cancelling a dialog should leave existing state unchanged.
Comment 5 WebKit Commit Bot 2011-04-05 02:07:03 PDT 
Comment on attachment 83757 [details]
Patch

Clearing flags on attachment: 83757

Committed r82914: <http://trac.webkit.org/changeset/82914>
Comment 6 WebKit Commit Bot 2011-04-05 02:07:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 WebKit Review Bot 2011-04-05 03:50:36 PDT 
http://trac.webkit.org/changeset/82914 might have broken GTK Linux 32-bit Debug