Bug 55190 - Crash when trying to send a sync message on an invalid connection
Summary: Crash when trying to send a sync message on an invalid connection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-24 15:36 PST by Anders Carlsson
Modified: 2011-02-25 09:54 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2011-02-24 15:39 PST, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-02-24 15:36:35 PST 
Crash when trying to send a sync message on an invalid connection
Comment 1 Anders Carlsson 2011-02-24 15:39:06 PST 
Created attachment 83734 [details]
Patch
Comment 2 mitz 2011-02-24 15:40:25 PST 
Comment on attachment 83734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83734&action=review

> Source/WebKit2/ChangeLog:11
> +        Don't try to call a client function is isValid() returns false since the client

s/n is/n if/
Comment 3 Anders Carlsson 2011-02-24 15:40:58 PST 
Committed r79634: <http://trac.webkit.org/changeset/79634>
Comment 4 Alexey Proskuryakov 2011-02-24 22:52:18 PST 
So, all callers of sendSync() need to test for null return value again? This can't be right.
Comment 5 Anders Carlsson 2011-02-25 09:54:52 PST 
(In reply to comment #4)
> So, all callers of sendSync() need to test for null return value again? This can't be right.

You obviously can't call the client since the client is null!