Bug 55186 - RenderBoxModelObject::paintBoxShadow should bail earlier
Summary: RenderBoxModelObject::paintBoxShadow should bail earlier
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-24 14:50 PST by Simon Fraser (smfr)
Modified: 2011-02-24 20:48 PST (History)
2 users (show)

See Also:

Attachments
Patch (4.70 KB, patch)
2011-02-24 15:57 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (3.91 KB, patch)
2011-02-24 16:16 PST, Simon Fraser (smfr) 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-02-24 14:50:34 PST 
RenderBoxModelObject::paintBoxShadow() does some work before it looks to see if there are any shadows. It should just bail earlier.
Comment 1 Simon Fraser (smfr) 2011-02-24 15:57:20 PST 
Created attachment 83738 [details]
Patch
Comment 2 mitz 2011-02-24 16:02:38 PST 
(In reply to comment #0)
> RenderBoxModelObject::paintBoxShadow() does some work before it looks to see if there are any shadows. It should just bail earlier.

Sounds like a good idea.

(In reply to comment #1)
> Created an attachment (id=83738) [details]
> Patch

Looks like a different idea.

Why not return early from paintBoxShadow()?
Comment 3 Simon Fraser (smfr) 2011-02-24 16:16:13 PST 
Created attachment 83741 [details]
Patch
Comment 4 Simon Fraser (smfr) 2011-02-24 20:48:49 PST 
http://trac.webkit.org/changeset/79647