Bug 55184 - WebKit2: Image-based cursors do not work
Summary: WebKit2: Image-based cursors do not work
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
Keywords: InRadar
Depends on:
Reported: 2011-02-24 14:19 PST by Darin Adler
Modified: 2011-02-24 18:10 PST (History)
0 users

See Also:

Patch (21.07 KB, patch)
2011-02-24 14:35 PST, Darin Adler
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2011-02-24 14:19:45 PST
WebKit2: Image-based cursors do not work
Comment 1 Darin Adler 2011-02-24 14:35:11 PST
Created attachment 83722 [details]
Comment 2 Darin Adler 2011-02-24 14:35:58 PST
Comment 3 Anders Carlsson 2011-02-24 17:17:24 PST
Comment on attachment 83722 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=83722&action=review

> Source/WebKit2/Shared/WebCoreArgumentCoders.h:206
> +        if (cursor.type() != WebCore::Cursor::Custom)

This should be type instead of cursor.type().

> Source/WebKit2/Shared/WebCoreArgumentCoders.h:236
> +            return false;

You could check that the hot spot is actually inside the image here.
Comment 4 Darin Adler 2011-02-24 18:10:23 PST
Committed r79652: <http://trac.webkit.org/changeset/79652>