Bug 55183 – Expand ruby base when it is shorter than the ruby text

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

As shown in <http://www.w3.org/TR/jlreq/#fig2_3_22-en>

<rdar://problem/8902740>

Created attachment 83719 [details]
Justify and inset ruby base

[Dave Hyatt]

Comment on attachment 83719 [details]
Justify and inset ruby base

View in context: https://bugs.webkit.org/attachment.cgi?id=83719&action=review

r=me

> Source/WebCore/rendering/RenderBlock.h:493
> +    virtual ETextAlign alignmentForLine(bool endsWithSoftBreak) const;

I think the method name here sounds ambiguous.  I'd prefer textAlignmentForLine so that nobody can confuse it with vertical-align.

Fixed in r79629.
http://trac.webkit.org/changeset/79629

[James Robinson]

This changed the result of a few ruby tests and I'm not sure if the new output is correct.  For example on:
http://trac.webkit.org/export/79639/trunk/LayoutTests/fast/ruby/ruby-beforeafter.html

prior to this patch the "b" beneath "long text" was centered, but now it's rendering to the left.
before:
http://svn.webkit.org/repository/webkit/trunk/LayoutTests/platform/mac/fast/ruby/ruby-beforeafter-expected.png
after:
http://build.chromium.org/f/chromium/layout_test_results/Webkit_Mac10_5/results/layout-test-results/fast/ruby/ruby-beforeafter-actual.png

is this a progression?  there are about 15 tests that show this sort of change

[James Robinson]

Tab tells me that this behavior is UA-defined, but centered is recommended.

Thanks, I am going to re-center.

Filed bug 55197