Bug 55182 – Clean up temp files left by crashing DRTs on chromium-win

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Chang]

Clean up temp files left by crashing DRTs on chromium-win

[Tony Chang]

Created attachment 83718 [details]
Patch

[Tony Chang]

We were getting problems on the Chromium Win Release (Tests) bot when we ran out of scoped_dirs (only 32k possible).

[James Robinson]

Comment on attachment 83718 [details]
Patch

Looks good!

[Tony Chang]

Committed r79724: <http://trac.webkit.org/changeset/79724>

[Tony Chang]

wms: Would you be so kind as to schedule a graceful master restart?  Thanks!

[WebKit Review Bot]

http://trac.webkit.org/changeset/79724 might have broken GTK Linux 32-bit Release, GTK Linux 32-bit Debug, and Qt Linux Release
The following tests are not passing:
fast/table/fixed-with-auto-with-colspan-vertical.html

[William Siegrist]

buildbot restarted

[Ojan Vafai]

Comment on attachment 83718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83718&action=review

> Tools/BuildSlaveSupport/chromium/remove-crash-logs:37
> +    if sys.platform == 'linux2':
> +        os.system('rm -rf /tmp/.org.chromium.*')
> +    elif 'win' in sys.platform:
> +        os.system('for /d %d in (%TEMP%\scoped_dir*) do rd /s /q "%d"')

Why no mac?

[Tony Chang]

(In reply to comment #8)
> (From update of attachment 83718 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=83718&action=review
> 
> > Tools/BuildSlaveSupport/chromium/remove-crash-logs:37
> > +    if sys.platform == 'linux2':
> > +        os.system('rm -rf /tmp/.org.chromium.*')
> > +    elif 'win' in sys.platform:
> > +        os.system('for /d %d in (%TEMP%\scoped_dir*) do rd /s /q "%d"')
> 
> Why no mac?

They haven't caused a problem yet, but I'll ssh to the bots and see if they also need some cleanup code (I'm also not sure where they store temp files).