UNCONFIRMED 55168
[GTK] [check-webkit-style] check-webkit-style fails when checking sorting order for webkit.h 
https://bugs.webkit.org/show_bug.cgi?id=55168
Summary [GTK] [check-webkit-style] check-webkit-style fails when checking sorting ord...
Lukasz Slachciak
Reported 2011-02-24 11:39:50 PST
In webkit.h, GTK port API file, there is a list of includes .... #include <webkit/webkitversion.h #include <webkit/webkitapplicationcache.h> #include <webkit/webkitdefines.h> #include <webkit/webkitdom.h> .... Because webkitversion defines the webkit major and minor version it should be always on the top of list. Unfortunately check-webkit-style fails, like in case of this bug: In bug https://bugs.webkit.org/show_bug.cgi?id=54823
Attachments
patch (2.04 KB, patch)
2011-02-27 01:58 PST, Kamil Blank 		mrobinson: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kamil Blank
Comment 1 2011-02-27 01:58:42 PST
Created attachment 83970 [details] patch Patch for skipping webkitversion.h when checking ordering rule.
Martin Robinson
Comment 2 2011-02-28 14:59:09 PST
Comment on attachment 83970 [details] patch Instead of adding a new header type, I think that it's better to just skip this file by modifying checker.py.
Martin Robinson
Comment 3 2011-02-28 14:59:24 PST
Thanks for taking care of this, by the way!
Note You need to log in before you can comment on or make changes to this bug.