Qt 4.8 will have QNAM use its own thread internally by default, no need to keep this complexity in WebKit. This mainly reverts: http://trac.webkit.org/changeset/73710 http://trac.webkit.org/changeset/73712
Created attachment 83670 [details] Patch
Maybe we should do this after 4.8 has actually been released?
(In reply to comment #2) > Maybe we should do this after 4.8 has actually been released? There's no point in waiting. We're not going to release anything based on trunk before Qt 4.8 anyway, and that will include the threaded HTTP backend for QNAM.
Committed r79668: <http://trac.webkit.org/changeset/79668>
I'm with Kenneth on this one. QtNetwork 4.8 is not release yet, so all the benchmarking etc. we're doing for the trunk is impacted.
(In reply to comment #5) > I'm with Kenneth on this one. > > QtNetwork 4.8 is not release yet, so all the benchmarking etc. we're doing for the trunk is impacted. What is the relevance of those benchmarks? We already know that the next release based on trunk is going to be with Qt 4.8, and it will have threaded HTTP in-Qt.
(In reply to comment #5) > I'm with Kenneth on this one. > > QtNetwork 4.8 is not release yet, so all the benchmarking etc. we're doing for the trunk is impacted. It's better to at least get this in *for* 4.8. We could wait and do it in the QtWebKit 2.2 branch and merge it in trunk after. However it would make merging any network work harder between trunk and the branch. Were you spawning you benchmark QNAM in a secondary thread? AFAIK, only QtTestBrowser was currently doing it by default, other QtWebKit apps shouldn't feel any regression from this revert patch.