Discussed this issue with eric carlson, and we think when HTMLMediaElement::mediaPlayerVolumeChanged gets callback, a volumechangeEvent event should be fired if the volume gets changed.
Created attachment 83660 [details] first try
Comment on attachment 83660 [details] first try View in context: https://bugs.webkit.org/attachment.cgi?id=83660&action=review > Source/WebCore/ChangeLog:16 > + (WebCore::HTMLMediaElement::setMuted): > + (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): > + I would really prefer to have comments here about what changed in each function.
Created attachment 83668 [details] updated with eric's suggestion Thanks for reviewing it, eric :)
Comment on attachment 83668 [details] updated with eric's suggestion Thanks!
Comment on attachment 83668 [details] updated with eric's suggestion Clearing flags on attachment: 83668 Committed r79768: <http://trac.webkit.org/changeset/79768>
All reviewed patches have been landed. Closing bug.
Revision r79768 cherry-picked into qtwebkit-2.1.x with commit 847d993 <http://gitorious.org/webkit/qtwebkit/commit/847d993>