Bug 55134 - [chromium] WebFrameImpl::m_totalMatchCount should be an int
Summary: [chromium] WebFrameImpl::m_totalMatchCount should be an int
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-24 05:08 PST by John Mellor
Modified: 2011-02-26 00:59 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.47 KB, patch)
2011-02-24 05:09 PST, John Mellor 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Mellor 2011-02-24 05:08:02 PST 
[chromium] WebFrameImpl::m_totalMatchCount should be an int
Comment 1 John Mellor 2011-02-24 05:09:48 PST 
Created attachment 83637 [details]
Patch
Comment 2 Benjamin Poulain 2011-02-24 06:45:24 PST 
No test possible?
Comment 3 John Mellor 2011-02-24 06:57:29 PST 
This is just a trivial cleanup - the variable is documented as sometimes being -1, and is indeed initialized to -1 by the constructor, so shouldn't be using an unsigned type.

In practice this won't change any behavior as the code happens to never depend on the signedness, hence it would be tricky to test.
Comment 4 John Mellor 2011-02-24 09:53:10 PST 
Comment on attachment 83637 [details]
Patch

Thanks for the review. Could someone add this to the commit queue please?
Comment 5 Eric Seidel (no email) 2011-02-24 13:38:51 PST 
Comment on attachment 83637 [details]
Patch

How do we test this?
Comment 6 Steve Block 2011-02-25 03:20:47 PST 
> How do we test this?
As John suggested, this is a trivial fix and the current behaviour is OK, so I don't think it's valuable to try to craft a regression test.
Comment 7 WebKit Commit Bot 2011-02-26 00:59:54 PST 
Comment on attachment 83637 [details]
Patch

Clearing flags on attachment: 83637

Committed r79767: <http://trac.webkit.org/changeset/79767>
Comment 8 WebKit Commit Bot 2011-02-26 00:59:59 PST 
All reviewed patches have been landed.  Closing bug.