Bug 55125 - Fix http://crbug.com/33358
Summary: Fix http://crbug.com/33358
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-24 01:23 PST by Xianzhu Wang
Modified: 2011-02-26 00:13 PST (History)
1 user (show)

See Also:


Attachments
patch (2.62 KB, patch)
2011-02-24 01:27 PST, Xianzhu Wang
no flags Details | Formatted Diff | Diff
Updated patch. The last patch file is broken (2.62 KB, patch)
2011-02-24 01:36 PST, Xianzhu Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2011-02-24 01:23:59 PST
I just ran the test on chromium-linux and chromium-win, the actual results are all the same as fast/dom/Window/window-postmessage-clone-frames.html, but different from platform/win/fast/dom/Window/window-postmessage-clone-frames.html (which is used as the expectation). Is this the same situation as when this issue was filed? If yes, the test actually passes on chromium. The failure is just caused by the different expectation under platform/win which in fact fails to run the test.
Comment 1 Xianzhu Wang 2011-02-24 01:27:10 PST
Created attachment 83618 [details]
patch
Comment 2 Xianzhu Wang 2011-02-24 01:36:42 PST
Created attachment 83621 [details]
Updated patch. The last patch file is broken
Comment 3 Eric Seidel (no email) 2011-02-24 02:24:42 PST
Comment on attachment 83621 [details]
Updated patch. The last patch file is broken

I take it that main WebKIt does not pass this test?
Comment 4 Xianzhu Wang 2011-02-24 02:54:09 PST
(In reply to comment #3)
> (From update of attachment 83621 [details])
> I take it that main WebKIt does not pass this test?

platform/win has rebaselined the expectation of this test which expects a failure of eventSender.beginDragWithFiles(...)).
Comment 5 WebKit Commit Bot 2011-02-26 00:13:45 PST
Comment on attachment 83621 [details]
Updated patch. The last patch file is broken

Clearing flags on attachment: 83621

Committed r79763: <http://trac.webkit.org/changeset/79763>
Comment 6 WebKit Commit Bot 2011-02-26 00:13:50 PST
All reviewed patches have been landed.  Closing bug.