Bug 55123 - [NRWT] Remove test_types/* classes finally.
Summary: [NRWT] Remove test_types/* classes finally.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 51091
  Show dependency tree / graph
 
Reported: 2011-02-24 00:50 PST by Hayato Ito
Modified: 2011-02-27 21:19 PST (History)
4 users (show)

See Also:

Attachments
remove-test-types (29.22 KB, patch)
2011-02-24 01:18 PST, Hayato Ito 		eric: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2011-02-24 00:50:59 PST 
This will be a final patch to eliminate test_types/* classes.

Please see a master bug for the background:
https://bugs.webkit.org/show_bug.cgi?id=51091

This patch should be just a refactoring, mainly moving code in test_types/* classes into single_test_runner.py.
But there is one visible change. We won't display statistics per TEST_TYPE any more by this patch.
Comment 1 Hayato Ito 2011-02-24 01:18:43 PST 
Created attachment 83616 [details]
remove-test-types
Comment 2 Eric Seidel (no email) 2011-02-24 02:26:14 PST 
Comment on attachment 83616 [details]
remove-test-types

OK.  rs=me.
Comment 3 WebKit Commit Bot 2011-02-24 12:28:06 PST 
Comment on attachment 83616 [details]
remove-test-types

Rejecting attachment 83616 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'ap..." exit_code: 2

Last 500 characters of output:
rm 'Tools/Scripts/webkitpy/layout_tests/test_types/test_type_base.py'
patching file Tools/Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py
rm 'Tools/Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py'
patching file Tools/Scripts/webkitpy/layout_tests/test_types/text_diff.py
rm 'Tools/Scripts/webkitpy/layout_tests/test_types/text_diff.py'

Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 2

Full output: http://queues.webkit.org/results/7984544
Comment 4 Hayato Ito 2011-02-27 21:19:19 PST 
Committed r79840: <http://trac.webkit.org/changeset/79840>