Bug 55121 – French (fr) sorting does not use 'backward' rule any more with ICU 4.6

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jungshik Shin]

French (fr_FR and many fr_FOO other than fr_CA) sorting does not use 'backward first accent weighting' rules any more. Thus, CLDR 1.9 and ICU 4.6 have different sorting for fr_FOO (where FOO !=CA) and fr_CA. 

fast/xsl/sort-locale has the expectation that treats both the same. Because other ports of Webkit still use old rules while Chrome with ICU 4.6 uses new rules, the expected result should go in platform/chromium. 

I'm making a patch.

[Hajime Morrita]

Thank you for filing this! I've also filed Bug 55118 so Could you close it after fix this?

[Tony Chang]

*** Bug 55118 has been marked as a duplicate of this bug. ***

[Jungshik Shin]

Created attachment 83903 [details]
add chromium-specific expectation file

[Jungshik Shin]

Created attachment 83904 [details]
same as above but a diff from the main expectation to be made clear using 'svn cp'

[Tony Chang]

Should there also be an updated to test_expectations.txt?

[WebKit Commit Bot]

Comment on attachment 83904 [details]
same as above but a diff from the main expectation to be made clear using 'svn cp' 

Rejecting attachment 83904 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2

Last 500 characters of output:
ebkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Tony Chang', u'--force']" exit_code: 2

Parsed 3 diffs from patch file(s).
cp: fast/xsl/sort-locale-expected.txt: No such file or directory
Failed to copy fast/xsl/sort-locale-expected.txt platform/chromium/fast/xsl/sort-locale-expected.txt. at /mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply line 427.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Tony Chang', u'--force']" exit_code: 2

Full output: http://queues.webkit.org/results/8070423

[Tony Chang]

(In reply to comment #6)
> Parsed 3 diffs from patch file(s).
> cp: fast/xsl/sort-locale-expected.txt: No such file or directory
> Failed to copy fast/xsl/sort-locale-expected.txt platform/chromium/fast/xsl/sort-locale-expected.txt. at /mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply line 427.
> 
> Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Tony Chang', u'--force']" exit_code: 2
> 
> Full output: http://queues.webkit.org/results/8070423

The diff around the copy looks weird (it's relative to a different path than the other 2 files).

[Jungshik Shin]

Thank you for the review. 

The patch creating script does something strange in this case. Anyway, I manually landed the patch with the correct path.  ( http://trac.webkit.org/changeset/79912 ). 

Later, I'll update test_expectations.txt as well. 


































Thank you for the review. 

The patch creating script does something strange in this case. Anyway, I manually landed the patch with the correct path ( http://trac.webkit.org/changeset/79912 ). 

I forgot