Bug 55109 – REGRESSION(r79396): gmail is not rendered correctly on TOT

• Status: RESOLVED
• Resolution: FIXED
• Component: Evangelism

[Ryosuke Niwa]

Gmail's inbox has extra padding in each line on TOT but it doesn't have such a padding on Safari / Chrome.  In fact, this is a regression happened in the last 48 hours.

[Ryosuke Niwa]

Created attachment 83595 [details]
correct (Safari)

[Ryosuke Niwa]

Created attachment 83596 [details]
incorrect (WebKit TOT)

[Alexey Proskuryakov]

<rdar://problem/9046033>

[Ryosuke Niwa]

I suspect that this is due to http://trac.webkit.org/changeset/79396/.

[Ryosuke Niwa]

Confirmed.  This is a regression due to r79396.  Perhaps we can't drop the language name given.  I'm afraid that numerous other websites might be broken due to this change.

[Ryosuke Niwa]

http://crbug.com/73959.

[Ojan Vafai]

Gmail uses a Closure's UA parsing code (http://www.google.com/codesearch/p?hl=en#epIciakqvFc/trunk/closure/goog/useragent/useragent.js&q=userAgent%20package:http://closure-library%5C.googlecode%5C.com&sa=N&cd=1&ct=rc), so there are likely a lot of Google, and possibly non-Google, products that will have problems here. Although, I'm not at all sure what's going wrong here.

In either case, we can certainly get the library fixed. It's just a question of how long all the sites that use the code have this problem. I'll see if I can figure out what problem this is actually causing.

[Ojan Vafai]

Actually, sorry, looking at that code, there's no way that's the culprit. Maybe it's server-side UA detection.

[Ojan Vafai]

Looks like the padding on the TDs in each row gets overridden. On tip-of-tree it doesn't.

[Ryosuke Niwa]

Created attachment 83599 [details]
fixes the bug

[Alexey Proskuryakov]

Comment on attachment 83599 [details]
fixes the bug

Wrong bug.

[Ryosuke Niwa]

(In reply to comment #11)
> (From update of attachment 83599 [details])
> Wrong bug.

Oops! My bad :(

[Emil A Eklund]

Gmail uses server side user agent detection to determine which version of the stylesheet to send. I'll talk to the gmail team.

[Ryosuke Niwa]

It seems like Google is going to fix the server-side UA string parser to resolve this particular issue.  But I bet there are similar regressions happening all over the place.  Do we have any plans to do some sort of public announcements?  A blog post would work.

[Ryosuke Niwa]

Created attachment 83922 [details]
incorrect rendering of thread view

[Alexey Proskuryakov]

*** Bug 55398 has been marked as a duplicate of this bug. ***

[Ryosuke Niwa]

*** Bug 55390 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

> It seems like Google is going to fix the server-side UA string parser to resolve this particular issue.

Did you happen to get an ETA for that?

[Peter Kasting]

(In reply to comment #18)
> > It seems like Google is going to fix the server-side UA string parser to resolve this particular issue.
> 
> Did you happen to get an ETA for that?

Yes, it should be available within a week.

[Peter Kasting]

I'm going to mark this WONTFIX since the issue is server-side, and the server code has already been fixed and just needs to be pushed out.

[Alexey Proskuryakov]

Evangelism/FIXED seems more appropriate. It's not like we decided that GMail looking bad doesn't need fixing!

[Jason Levine]

(In reply to comment #19)

Peter et al, is there any chance that this fix is going to be pushed out soon? This isn't a *huge* deal, but the server-side bug really is impairing the usability of Gmail on Chrome right now.

[Peter Kasting]

(In reply to comment #22)
> (In reply to comment #19)
> 
> Peter et al, is there any chance that this fix is going to be pushed out soon? This isn't a *huge* deal, but the server-side bug really is impairing the usability of Gmail on Chrome right now.

The fix has already been pushed for many people.

[Jason Levine]

(In reply to comment #23)
> The fix has already been pushed for many people.

On the off chance, is there something I need to do at my end to get my Google Mail session to "see" the new pushed stylesheet fixes? I've now logged into all four of my different Gmail accounts (personal, work, etc.), and am not seeing the fix on *any* of them.

[Peter Kasting]

(In reply to comment #24)
> (In reply to comment #23)
> > The fix has already been pushed for many people.
> 
> On the off chance, is there something I need to do at my end to get my Google Mail session to "see" the new pushed stylesheet fixes? I've now logged into all four of my different Gmail accounts (personal, work, etc.), and am not seeing the fix on *any* of them.

I'm sorry, I don't know the details of the gmail team's deployment plan.  I would try clearing cache and cookies, and, failing that, fall back on using the stable build for a while.